revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-23 14:00:56 +01:00
Code Issues Releases Wiki Activity

Remove bad "Session" link in User activity logs

Browse source 
Summary:
Fixes T12215. Two issues:

  - We build this `$session` link out of `$ip`, which is (a) wrong even if `$ip` was the IP and (b) super wrong since `$ip` is a tag.
  - These links don't work even if we'd built them right: searching by the //prefix// of a session identifier does nothing.

At least for now, just get rid of the links rather than trying to make this behavior work.

Test Plan:
On People > Activity logs:

  - Before patch: Saw bad links with bogus targets in "session" column.
  - After patch: Saw plain text in "session" column.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12215

Differential Revision: https://secure.phabricator.com/D17316
This commit is contained in:
epriestley 2017-02-06 04:26:43 -08:00
parent 3d44208e4f
commit 75abf79953
1 changed files with 0 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/applications/people/view/PhabricatorUserLogView.php
View file

@ -43,12 +43,6 @@ final class PhabricatorUserLogView extends AphrontView {
'href' => $base_uri.'?ip='.$ip.'#R', 'href' => $base_uri.'?ip='.$ip.'#R',
), ),
$ip); $ip);
$session = phutil_tag(
'a',
array(
'href' => $base_uri.'?sessions='.$ip.'#R',
),
$session);
} }
$action = $log->getAction(); $action = $log->getAction();