revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-22 14:52:41 +01:00
Code Issues Releases Wiki Activity

Don't jump to symbol after selecting

Browse source 
Summary: Selecting text still triggers 'click' event.

Test Plan:
Selected symbol.
Clicked symbol.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D3197
This commit is contained in:
vrana 2012-08-08 12:38:41 -07:00
parent 386735a39d
commit 75c647c932
2 changed files with 24 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

42
src/__celerity_resource_map__.php
View file

@ -1635,7 +1635,7 @@ celerity_register_resource_map(array(
), ),
'javelin-behavior-repository-crossreference' => 'javelin-behavior-repository-crossreference' =>
array( array(
'uri' => '/res/345ad6b3/rsrc/js/application/repository/repository-crossreference.js', 'uri' => '/res/e0d58d3b/rsrc/js/application/repository/repository-crossreference.js',
'type' => 'js', 'type' => 'js',
'requires' => 'requires' =>
array( array(
@ -2867,7 +2867,7 @@ celerity_register_resource_map(array(
'uri' => '/res/pkg/96bc37d6/differential.pkg.css', 'uri' => '/res/pkg/96bc37d6/differential.pkg.css',
'type' => 'css', 'type' => 'css',
), ),
'6617163c' => 'ace0431a' =>
array( array(
'name' => 'differential.pkg.js', 'name' => 'differential.pkg.js',
'symbols' => 'symbols' =>
@ -2891,7 +2891,7 @@ celerity_register_resource_map(array(
16 => 'javelin-behavior-differential-dropdown-menus', 16 => 'javelin-behavior-differential-dropdown-menus',
17 => 'javelin-behavior-buoyant', 17 => 'javelin-behavior-buoyant',
), ),
'uri' => '/res/pkg/6617163c/differential.pkg.js', 'uri' => '/res/pkg/ace0431a/differential.pkg.js',
'type' => 'js', 'type' => 'js',
), ),
'c8ce2d88' => 'c8ce2d88' =>
@ -2999,7 +2999,7 @@ celerity_register_resource_map(array(
'aphront-typeahead-control-css' => '8b65e80d', 'aphront-typeahead-control-css' => '8b65e80d',
'differential-changeset-view-css' => '96bc37d6', 'differential-changeset-view-css' => '96bc37d6',
'differential-core-view-css' => '96bc37d6', 'differential-core-view-css' => '96bc37d6',
'differential-inline-comment-editor' => '6617163c', 'differential-inline-comment-editor' => 'ace0431a',
'differential-local-commits-view-css' => '96bc37d6', 'differential-local-commits-view-css' => '96bc37d6',
'differential-results-table-css' => '96bc37d6', 'differential-results-table-css' => '96bc37d6',
'differential-revision-add-comment-css' => '96bc37d6', 'differential-revision-add-comment-css' => '96bc37d6',
@ -3012,21 +3012,21 @@ celerity_register_resource_map(array(
'inline-comment-summary-css' => '96bc37d6', 'inline-comment-summary-css' => '96bc37d6',
'javelin-behavior' => '6fb20113', 'javelin-behavior' => '6fb20113',
'javelin-behavior-aphront-basic-tokenizer' => '97f65640', 'javelin-behavior-aphront-basic-tokenizer' => '97f65640',
'javelin-behavior-aphront-drag-and-drop' => '6617163c', 'javelin-behavior-aphront-drag-and-drop' => 'ace0431a',
'javelin-behavior-aphront-drag-and-drop-textarea' => '6617163c', 'javelin-behavior-aphront-drag-and-drop-textarea' => 'ace0431a',
'javelin-behavior-aphront-form-disable-on-submit' => '971b021e', 'javelin-behavior-aphront-form-disable-on-submit' => '971b021e',
'javelin-behavior-audit-preview' => '5e68be89', 'javelin-behavior-audit-preview' => '5e68be89',
'javelin-behavior-buoyant' => '6617163c', 'javelin-behavior-buoyant' => 'ace0431a',
'javelin-behavior-differential-accept-with-errors' => '6617163c', 'javelin-behavior-differential-accept-with-errors' => 'ace0431a',
'javelin-behavior-differential-add-reviewers-and-ccs' => '6617163c', 'javelin-behavior-differential-add-reviewers-and-ccs' => 'ace0431a',
'javelin-behavior-differential-comment-jump' => '6617163c', 'javelin-behavior-differential-comment-jump' => 'ace0431a',
'javelin-behavior-differential-diff-radios' => '6617163c', 'javelin-behavior-differential-diff-radios' => 'ace0431a',
'javelin-behavior-differential-dropdown-menus' => '6617163c', 'javelin-behavior-differential-dropdown-menus' => 'ace0431a',
'javelin-behavior-differential-edit-inline-comments' => '6617163c', 'javelin-behavior-differential-edit-inline-comments' => 'ace0431a',
'javelin-behavior-differential-feedback-preview' => '6617163c', 'javelin-behavior-differential-feedback-preview' => 'ace0431a',
'javelin-behavior-differential-keyboard-navigation' => '6617163c', 'javelin-behavior-differential-keyboard-navigation' => 'ace0431a',
'javelin-behavior-differential-populate' => '6617163c', 'javelin-behavior-differential-populate' => 'ace0431a',
'javelin-behavior-differential-show-more' => '6617163c', 'javelin-behavior-differential-show-more' => 'ace0431a',
'javelin-behavior-diffusion-commit-graph' => '5e68be89', 'javelin-behavior-diffusion-commit-graph' => '5e68be89',
'javelin-behavior-diffusion-pull-lastmodified' => '5e68be89', 'javelin-behavior-diffusion-pull-lastmodified' => '5e68be89',
'javelin-behavior-maniphest-batch-selector' => '7707de41', 'javelin-behavior-maniphest-batch-selector' => '7707de41',
@ -3036,12 +3036,12 @@ celerity_register_resource_map(array(
'javelin-behavior-maniphest-transaction-preview' => '7707de41', 'javelin-behavior-maniphest-transaction-preview' => '7707de41',
'javelin-behavior-phabricator-autofocus' => '971b021e', 'javelin-behavior-phabricator-autofocus' => '971b021e',
'javelin-behavior-phabricator-keyboard-shortcuts' => '971b021e', 'javelin-behavior-phabricator-keyboard-shortcuts' => '971b021e',
'javelin-behavior-phabricator-object-selector' => '6617163c', 'javelin-behavior-phabricator-object-selector' => 'ace0431a',
'javelin-behavior-phabricator-oncopy' => '971b021e', 'javelin-behavior-phabricator-oncopy' => '971b021e',
'javelin-behavior-phabricator-tooltips' => '971b021e', 'javelin-behavior-phabricator-tooltips' => '971b021e',
'javelin-behavior-phabricator-watch-anchor' => '971b021e', 'javelin-behavior-phabricator-watch-anchor' => '971b021e',
'javelin-behavior-refresh-csrf' => '971b021e', 'javelin-behavior-refresh-csrf' => '971b021e',
'javelin-behavior-repository-crossreference' => '6617163c', 'javelin-behavior-repository-crossreference' => 'ace0431a',
'javelin-behavior-workflow' => '971b021e', 'javelin-behavior-workflow' => '971b021e',
'javelin-dom' => '6fb20113', 'javelin-dom' => '6fb20113',
'javelin-event' => '6fb20113', 'javelin-event' => '6fb20113',
@ -3067,7 +3067,7 @@ celerity_register_resource_map(array(
'phabricator-core-buttons-css' => '8b65e80d', 'phabricator-core-buttons-css' => '8b65e80d',
'phabricator-core-css' => '8b65e80d', 'phabricator-core-css' => '8b65e80d',
'phabricator-directory-css' => '8b65e80d', 'phabricator-directory-css' => '8b65e80d',
'phabricator-drag-and-drop-file-upload' => '6617163c', 'phabricator-drag-and-drop-file-upload' => 'ace0431a',
'phabricator-dropdown-menu' => '971b021e', 'phabricator-dropdown-menu' => '971b021e',
'phabricator-flag-css' => '8b65e80d', 'phabricator-flag-css' => '8b65e80d',
'phabricator-jump-nav' => '8b65e80d', 'phabricator-jump-nav' => '8b65e80d',
@ -3079,7 +3079,7 @@ celerity_register_resource_map(array(
'phabricator-prefab' => '971b021e', 'phabricator-prefab' => '971b021e',
'phabricator-project-tag-css' => '7839ae2d', 'phabricator-project-tag-css' => '7839ae2d',
'phabricator-remarkup-css' => '8b65e80d', 'phabricator-remarkup-css' => '8b65e80d',
'phabricator-shaped-request' => '6617163c', 'phabricator-shaped-request' => 'ace0431a',
'phabricator-standard-page-view' => '8b65e80d', 'phabricator-standard-page-view' => '8b65e80d',
'phabricator-tooltip' => '971b021e', 'phabricator-tooltip' => '971b021e',
'phabricator-transaction-view-css' => '8b65e80d', 'phabricator-transaction-view-css' => '8b65e80d',

3
webroot/rsrc/js/application/repository/repository-crossreference.js
View file

@ -17,6 +17,9 @@ JX.behavior('repository-crossreference', function(config) {
'click', 'click',
'tag:span', 'tag:span',
function(e) { function(e) {
if (window.getSelection && !window.getSelection().isCollapsed) {
return;
}
var target = e.getTarget(); var target = e.getTarget();
var map = {nc : 'class', nf : 'function'}; var map = {nc : 'class', nf : 'function'};
while (target !== document.body) { while (target !== document.body) {