revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-14 10:52:41 +01:00
Code Issues Releases Wiki Activity

Don't render an action list without actions

Browse source 
Summary: Skips rendering of partial elements if no actions are present.

Test Plan: Tested on profile menu item page, maniphest curtain, phriction dropdown, and instance backups page (no actions at all).

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D17931
This commit is contained in:
Chad Little 2017-05-17 09:06:07 -07:00
parent dde63af1cc
commit 75fb1a0327
3 changed files with 13 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
resources/celerity/map.php
View file

@ -9,7 +9,7 @@ return array(
'names' => array( 'names' => array(
'conpherence.pkg.css' => 'ff161f2d', 'conpherence.pkg.css' => 'ff161f2d',
'conpherence.pkg.js' => 'b5b51108', 'conpherence.pkg.js' => 'b5b51108',
'core.pkg.css' => 'ee5f28cd', 'core.pkg.css' => 'a5a2d647',
'core.pkg.js' => '0f87a6eb', 'core.pkg.js' => '0f87a6eb',
'darkconsole.pkg.js' => '1f9a31bc', 'darkconsole.pkg.js' => '1f9a31bc',
'differential.pkg.css' => 'ea471cb0', 'differential.pkg.css' => 'ea471cb0',
@ -145,7 +145,7 @@ return array(
'rsrc/css/phui/phui-comment-form.css' => '57af2e14', 'rsrc/css/phui/phui-comment-form.css' => '57af2e14',
'rsrc/css/phui/phui-comment-panel.css' => 'f50152ad', 'rsrc/css/phui/phui-comment-panel.css' => 'f50152ad',
'rsrc/css/phui/phui-crumbs-view.css' => '6ece3bbb', 'rsrc/css/phui/phui-crumbs-view.css' => '6ece3bbb',
'rsrc/css/phui/phui-curtain-view.css' => '679743bb', 'rsrc/css/phui/phui-curtain-view.css' => '55dd0e59',
'rsrc/css/phui/phui-document-pro.css' => '62c4dcbf', 'rsrc/css/phui/phui-document-pro.css' => '62c4dcbf',
'rsrc/css/phui/phui-document-summary.css' => '9ca48bdf', 'rsrc/css/phui/phui-document-summary.css' => '9ca48bdf',
'rsrc/css/phui/phui-document.css' => 'c32e8dec', 'rsrc/css/phui/phui-document.css' => 'c32e8dec',
@ -844,7 +844,7 @@ return array(
'phui-comment-form-css' => '57af2e14', 'phui-comment-form-css' => '57af2e14',
'phui-comment-panel-css' => 'f50152ad', 'phui-comment-panel-css' => 'f50152ad',
'phui-crumbs-view-css' => '6ece3bbb', 'phui-crumbs-view-css' => '6ece3bbb',
'phui-curtain-view-css' => '679743bb', 'phui-curtain-view-css' => '55dd0e59',
'phui-document-summary-view-css' => '9ca48bdf', 'phui-document-summary-view-css' => '9ca48bdf',
'phui-document-view-css' => 'c32e8dec', 'phui-document-view-css' => 'c32e8dec',
'phui-document-view-pro-css' => '62c4dcbf', 'phui-document-view-pro-css' => '62c4dcbf',

4
src/view/layout/PhabricatorActionListView.php
View file

@ -16,6 +16,10 @@ final class PhabricatorActionListView extends AphrontTagView {
} }
protected function getTagName() { protected function getTagName() {
if (!$this->actions) {
return null;
}
return 'ul'; return 'ul';
} }

7
webroot/rsrc/css/phui/phui-curtain-view.css
View file

@ -7,12 +7,17 @@
margin: 0 4px; margin: 0 4px;
} }
.phui-two-column-properties > .phui-curtain-panel:first-child {
padding-top: 6px;
}
.device .phui-curtain-panel { .device .phui-curtain-panel {
padding: 8px 0; padding: 8px 0;
margin: 0; margin: 0;
} }
.device-desktop .phui-curtain-panel { .device-desktop .phui-curtain-panel + .phui-curtain-panel,
.device-desktop .phabricator-action-list-view + .phui-curtain-panel {
border-top: 1px solid {$greybackground}; border-top: 1px solid {$greybackground};
} }