revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-22 23:02:42 +01:00
Code Issues Releases Wiki Activity

Strip non-integers out of task id entries

Browse source 
Test Plan: search in task ids for `t123, 456, pickles` (assuming 123 and 456 exist), and you will see 123 and 456 listed.  This is done in the buildQueryFromRequest function, so it would process a hand-written GET string just fine too.

Reviewers: epriestley

CC: aran, Korvin

Maniphest Tasks: T1365

Differential Revision: https://secure.phabricator.com/D2771
This commit is contained in:
Jonathan Lomas 2012-06-15 17:19:56 -07:00
parent 957f9e2ec5
commit 7629d44175
1 changed files with 18 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
src/applications/maniphest/controller/ManiphestTaskListController.php
View file

@ -661,6 +661,24 @@ final class ManiphestTaskListController extends ManiphestController {
$exclude_project_phids = $request->getStrList('xprojects');
$task_ids = $request->getStrList('tasks');
// We only need the integer portion of each task ID, so get rid of any non-
// numeric elements
$numeric_task_ids = array();
foreach ($task_ids as $task_id) {
$task_id = preg_replace('/[a-zA-Z]+/', '', $task_id);
if (!empty($task_id)) {
$numeric_task_ids[] = $task_id;
}
}
if (empty($numeric_task_ids)) {
$numeric_task_ids = array(null);
}
$task_ids = $numeric_task_ids;
$owner_phids = $request->getStrList('owners');
$author_phids = $request->getStrList('authors');