From 763d6dd3a72ac5e78881001b691877bd401e4238 Mon Sep 17 00:00:00 2001
From: Bob Trahan <btrahan@phacility.com>
Date: Thu, 28 Aug 2014 13:08:32 -0700
Subject: [PATCH] Diffusion - nuke faulty javascript error handler

Summary: Fixes T3913.

Test Plan: messed around with a comment on a commit and saw preview still updating correctly

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: epriestley, Korvin

Maniphest Tasks: T3913

Differential Revision: https://secure.phabricator.com/D10382
---
 resources/celerity/map.php                    | 22 +++++++++----------
 .../differential/behavior-comment-preview.js  |  4 ----
 2 files changed, 11 insertions(+), 15 deletions(-)

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
index cd199dec4b..603025e74d 100644
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -11,7 +11,7 @@ return array(
     'core.pkg.js' => 'f67c8265',
     'darkconsole.pkg.js' => 'df001cab',
     'differential.pkg.css' => '36884139',
-    'differential.pkg.js' => 'fe026527',
+    'differential.pkg.js' => '73337d1d',
     'diffusion.pkg.css' => '591664fa',
     'diffusion.pkg.js' => 'bfc0737b',
     'maniphest.pkg.css' => 'f5d89daf',
@@ -365,7 +365,7 @@ return array(
     'rsrc/js/application/differential/DifferentialInlineCommentEditor.js' => 'f2441746',
     'rsrc/js/application/differential/behavior-add-reviewers-and-ccs.js' => 'e10f8e18',
     'rsrc/js/application/differential/behavior-comment-jump.js' => '4fdb476d',
-    'rsrc/js/application/differential/behavior-comment-preview.js' => '127f2018',
+    'rsrc/js/application/differential/behavior-comment-preview.js' => '6932def3',
     'rsrc/js/application/differential/behavior-diff-radios.js' => 'e1ff79b1',
     'rsrc/js/application/differential/behavior-dropdown-menus.js' => '710f209e',
     'rsrc/js/application/differential/behavior-edit-inline-comments.js' => '00861799',
@@ -571,7 +571,7 @@ return array(
     'javelin-behavior-differential-diff-radios' => 'e1ff79b1',
     'javelin-behavior-differential-dropdown-menus' => '710f209e',
     'javelin-behavior-differential-edit-inline-comments' => '00861799',
-    'javelin-behavior-differential-feedback-preview' => '127f2018',
+    'javelin-behavior-differential-feedback-preview' => '6932def3',
     'javelin-behavior-differential-keyboard-navigation' => '8d199d97',
     'javelin-behavior-differential-populate' => 'bdb3e4d0',
     'javelin-behavior-differential-show-field-details' => 'bba9eedf',
@@ -906,14 +906,6 @@ return array(
       'javelin-uri',
       'javelin-install',
     ),
-    '127f2018' => array(
-      'javelin-behavior',
-      'javelin-stratcom',
-      'javelin-dom',
-      'javelin-request',
-      'javelin-util',
-      'phabricator-shaped-request',
-    ),
     '13c739ea' => array(
       'javelin-behavior',
       'javelin-stratcom',
@@ -1225,6 +1217,14 @@ return array(
       'javelin-dom',
       'javelin-fx',
     ),
+    '6932def3' => array(
+      'javelin-behavior',
+      'javelin-stratcom',
+      'javelin-dom',
+      'javelin-request',
+      'javelin-util',
+      'phabricator-shaped-request',
+    ),
     '69adf288' => array(
       'javelin-install',
     ),
diff --git a/webroot/rsrc/js/application/differential/behavior-comment-preview.js b/webroot/rsrc/js/application/differential/behavior-comment-preview.js
index c7b789d566..2fae03fd8c 100644
--- a/webroot/rsrc/js/application/differential/behavior-comment-preview.js
+++ b/webroot/rsrc/js/application/differential/behavior-comment-preview.js
@@ -39,10 +39,6 @@ JX.behavior('differential-feedback-preview', function(config) {
   };
 
   var request = new JX.PhabricatorShapedRequest(config.uri, callback, getdata);
-  request.listen('error', function (error) {
-    JX.DOM.setContent(JX.$(config.preview), JX.$H('ERROR: ' + error.info));
-  });
-
   var trigger = JX.bind(request, request.trigger);
 
   JX.DOM.listen(content, 'keydown', null, trigger);