revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-27 01:02:42 +01:00
Code Issues Releases Wiki Activity

Remarkup - add underline rule

Browse source 
Summary: we need this for legalese. Ref T3116

Test Plan: made a legalpad document with underlines. also re-gened docs and noted underlines worked

Reviewers: epriestley

Reviewed By: epriestley

CC: Korvin, epriestley, aran

Maniphest Tasks: T3116

Differential Revision: https://secure.phabricator.com/D7996
This commit is contained in:
Bob Trahan 2014-01-17 13:11:26 -08:00
parent 220addb249
commit 7686efb896
2 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/docs/user/userguide/remarkup.diviner
View file

@ -18,7 +18,7 @@ formatting text in Remarkup.
These are inline styles, and can be applied to most text: These are inline styles, and can be applied to most text:
**bold** //italic// ##monospaced## `monospaced` ~~deleted~~ **bold** //italic// ##monospaced## `monospaced` ~~deleted~~ __underlined__
D123 T123 rX123 # Link to Objects D123 T123 rX123 # Link to Objects
{D123} {T123} # Link to Objects (Full Name) {D123} {T123} # Link to Objects (Full Name)
{F123} # Embed Images {F123} # Embed Images
@ -58,9 +58,10 @@ Format **basic text styles** like this:
##monospaced text## ##monospaced text##
`monospaced text` `monospaced text`
~~deleted text~~ ~~deleted text~~
__underlined text__
Those produce **bold text**, //italic text//, ##monospaced text##, Those produce **bold text**, //italic text//, ##monospaced text##,
`monospaced text` and ~~deleted text~~, respectively. `monospaced text`, ~~deleted text~~, and __underlined text__, respectively.
= Layout = = Layout =

1
src/infrastructure/markup/PhabricatorMarkupEngine.php
View file

@ -455,6 +455,7 @@ final class PhabricatorMarkupEngine {
$rules[] = new PhutilRemarkupRuleBold(); $rules[] = new PhutilRemarkupRuleBold();
$rules[] = new PhutilRemarkupRuleItalic(); $rules[] = new PhutilRemarkupRuleItalic();
$rules[] = new PhutilRemarkupRuleDel(); $rules[] = new PhutilRemarkupRuleDel();
$rules[] = new PhutilRemarkupRuleUnderline();
foreach (self::loadCustomInlineRules() as $rule) { foreach (self::loadCustomInlineRules() as $rule) {
$rules[] = $rule; $rules[] = $rule;