mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-21 13:00:56 +01:00
Fix ContainsConstraints for array-valued custom field constraints in "*.search" methods
Summary: Fixes T11593. We ask for a list of values when searching for custom "link" fields, but don't handle it correctly when actually construcitng a query. Test Plan: Added this custom field: ``` { "mycompany.target-version": { "name": "Target Version", "type": "link", "search": true } } ``` Set a task to "beta". Let daemons index it. Queried for: ``` constraints: { "custom.mycompany.target-version": [ "beta" ] } ``` Got just one result back. Reviewers: chad Reviewed By: chad Maniphest Tasks: T11593 Differential Revision: https://secure.phabricator.com/D16508
This commit is contained in:
parent
38ae81fb39
commit
76af4d649b
1 changed files with 6 additions and 1 deletions
|
@ -47,7 +47,12 @@ final class PhabricatorStandardCustomFieldLink
|
|||
PhabricatorCursorPagedPolicyAwareQuery $query,
|
||||
$value) {
|
||||
|
||||
if (strlen($value)) {
|
||||
if (is_string($value) && !strlen($value)) {
|
||||
return;
|
||||
}
|
||||
|
||||
$value = (array)$value;
|
||||
if ($value) {
|
||||
$query->withApplicationSearchContainsConstraint(
|
||||
$this->newStringIndex(null),
|
||||
$value);
|
||||
|
|
Loading…
Reference in a new issue