revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-09-20 09:18:48 +02:00
Code Issues Releases Wiki Activity

Only hide archived project tags on workboard cards

Browse source 
Summary: Fixes T10413. I accidentally hid these //everywhere//, but only intended to hide them on workboards.

Test Plan:
  - Viewed a workboard, saw un-archived projects only.
  - Viewed a task detail page, saw archived and un-archived projects.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10413

Differential Revision: https://secure.phabricator.com/D15335
This commit is contained in:
epriestley 2016-02-23 10:44:30 -08:00
parent a112bc5cba
commit 76d4e85bfc
2 changed files with 10 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/applications/phid/view/PHUIHandleTagListView.php
View file

@ -52,13 +52,6 @@ final class PHUIHandleTagListView extends AphrontTagView {
protected function getTagContent() {
$handles = $this->handles;
// Remove any archived projects from the list.
foreach ($handles as $key => $handle) {
if ($handle->getStatus() == PhabricatorObjectHandle::STATUS_CLOSED) {
unset($handles[$key]);
}
}
// If the list is empty, we may render a "No Projects" tag.
if (!$handles) {
if (strlen($this->noDataString)) {

10
src/applications/project/view/ProjectBoardTaskCard.php
View file

@ -116,6 +116,16 @@ final class ProjectBoardTaskCard extends Phobject {
}
$project_handles = $this->getProjectHandles();
// Remove any archived projects from the list.
if ($project_handles) {
foreach ($project_handles as $key => $handle) {
if ($handle->getStatus() == PhabricatorObjectHandle::STATUS_CLOSED) {
unset($project_handles[$key]);
}
}
}
if ($project_handles) {
$tag_list = id(new PHUIHandleTagListView())
->setSlim(true)