From 7756484a000c18860bf18a3e6cc578db7f3da66a Mon Sep 17 00:00:00 2001 From: Joshua Spence Date: Wed, 7 Jan 2015 07:33:37 +1100 Subject: [PATCH] Fix method visibility for `AphrontFormControl` methods Summary: Ref T6822. Test Plan: Visual inspection. These methods are only called from within the `AphrontFormControl` class. Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6822 Differential Revision: https://secure.phabricator.com/D11249 --- src/applications/flag/view/PhabricatorFlagSelectControl.php | 4 ++-- .../releeph/view/branch/ReleephBranchPreviewView.php | 4 ++-- .../releeph/view/request/ReleephRequestTypeaheadControl.php | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/applications/flag/view/PhabricatorFlagSelectControl.php b/src/applications/flag/view/PhabricatorFlagSelectControl.php index f3a9c20aa2..0cc01fb123 100644 --- a/src/applications/flag/view/PhabricatorFlagSelectControl.php +++ b/src/applications/flag/view/PhabricatorFlagSelectControl.php @@ -2,11 +2,11 @@ final class PhabricatorFlagSelectControl extends AphrontFormControl { - public function getCustomControlClass() { + protected function getCustomControlClass() { return 'phabricator-flag-select-control'; } - public function renderInput() { + protected function renderInput() { require_celerity_resource('phabricator-flag-css'); $colors = PhabricatorFlagColor::getColorNameMap(); diff --git a/src/applications/releeph/view/branch/ReleephBranchPreviewView.php b/src/applications/releeph/view/branch/ReleephBranchPreviewView.php index e90861ae4c..d81f1f5d01 100644 --- a/src/applications/releeph/view/branch/ReleephBranchPreviewView.php +++ b/src/applications/releeph/view/branch/ReleephBranchPreviewView.php @@ -17,12 +17,12 @@ final class ReleephBranchPreviewView extends AphrontFormControl { return $this; } - public function getCustomControlClass() { + protected function getCustomControlClass() { require_celerity_resource('releeph-preview-branch'); return 'releeph-preview-branch'; } - public function renderInput() { + protected function renderInput() { static $required_params = array( 'arcProjectID', 'projectName', diff --git a/src/applications/releeph/view/request/ReleephRequestTypeaheadControl.php b/src/applications/releeph/view/request/ReleephRequestTypeaheadControl.php index 0cb9a7ed6d..e8ed53f946 100644 --- a/src/applications/releeph/view/request/ReleephRequestTypeaheadControl.php +++ b/src/applications/releeph/view/request/ReleephRequestTypeaheadControl.php @@ -17,11 +17,11 @@ final class ReleephRequestTypeaheadControl extends AphrontFormControl { return $this; } - public function getCustomControlClass() { + protected function getCustomControlClass() { return 'releeph-request-typeahead'; } - public function renderInput() { + protected function renderInput() { $id = celerity_generate_unique_node_id(); $div = phutil_tag(