Remove "Reviewed By" Differential field

Summary: Ref T11114. This is replaced by `DifferentialReviewedByCommitMessageField.php`.

Test Plan:
  - Used `differential.getcommitmessage` to query an accepted revision, saw "Reviewed By".
  - Grepped for removed class name.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11114

Differential Revision: https://secure.phabricator.com/D17079

src/__phutil_library_map__.php

@@ -494,7 +494,6 @@ phutil_register_library_map(array(
     'DifferentialRevertPlanCommitMessageField' => 'applications/differential/field/DifferentialRevertPlanCommitMessageField.php',
     'DifferentialRevertPlanField' => 'applications/differential/customfield/DifferentialRevertPlanField.php',
     'DifferentialReviewedByCommitMessageField' => 'applications/differential/field/DifferentialReviewedByCommitMessageField.php',
-    'DifferentialReviewedByField' => 'applications/differential/customfield/DifferentialReviewedByField.php',
     'DifferentialReviewerDatasource' => 'applications/differential/typeahead/DifferentialReviewerDatasource.php',
     'DifferentialReviewerForRevisionEdgeType' => 'applications/differential/edge/DifferentialReviewerForRevisionEdgeType.php',
     'DifferentialReviewerProxy' => 'applications/differential/storage/DifferentialReviewerProxy.php',
@@ -5146,7 +5145,6 @@ phutil_register_library_map(array(
     'DifferentialRevertPlanCommitMessageField' => 'DifferentialCommitMessageCustomField',
     'DifferentialRevertPlanField' => 'DifferentialStoredCustomField',
     'DifferentialReviewedByCommitMessageField' => 'DifferentialCommitMessageField',
-    'DifferentialReviewedByField' => 'DifferentialCoreCustomField',
     'DifferentialReviewerDatasource' => 'PhabricatorTypeaheadCompositeDatasource',
     'DifferentialReviewerForRevisionEdgeType' => 'PhabricatorEdgeType',
     'DifferentialReviewerProxy' => 'Phobject',

src/applications/differential/config/PhabricatorDifferentialConfigOptions.php

@@ -30,7 +30,6 @@ final class PhabricatorDifferentialConfigOptions
       new DifferentialTestPlanField(),
       new DifferentialReviewersField(),
       new DifferentialProjectReviewersField(),
-      new DifferentialReviewedByField(),
       new DifferentialSubscribersField(),
       new DifferentialRepositoryField(),
       new DifferentialViewPolicyField(),

src/applications/differential/customfield/DifferentialReviewedByField.php

@@ -1,68 +0,0 @@
-<?php
-
-final class DifferentialReviewedByField
-  extends DifferentialCoreCustomField {
-
-  public function getFieldKey() {
-    return 'differential:reviewed-by';
-  }
-
-  public function getFieldKeyForConduit() {
-    return 'reviewedByPHIDs';
-  }
-
-  public function getFieldName() {
-    return pht('Reviewed By');
-  }
-
-  public function getFieldDescription() {
-    return pht('Records accepting reviewers in the durable message.');
-  }
-
-  public function shouldAppearInApplicationTransactions() {
-    return false;
-  }
-
-  public function canDisableField() {
-    return true;
-  }
-
-  protected function readValueFromRevision(
-    DifferentialRevision $revision) {
-
-    $phids = array();
-    foreach ($revision->getReviewerStatus() as $reviewer) {
-      switch ($reviewer->getStatus()) {
-        case DifferentialReviewerStatus::STATUS_ACCEPTED:
-        case DifferentialReviewerStatus::STATUS_ACCEPTED_OLDER:
-          $phids[] = $reviewer->getReviewerPHID();
-          break;
-      }
-    }
-
-    return $phids;
-  }
-
-  public function shouldAppearInCommitMessage() {
-    return true;
-  }
-
-  public function parseValueFromCommitMessage($value) {
-    return $this->parseObjectList(
-      $value,
-      array(
-        PhabricatorPeopleUserPHIDType::TYPECONST,
-        PhabricatorProjectProjectPHIDType::TYPECONST,
-      ),
-      $allow_partial = true);
-  }
-
-  public function getRequiredHandlePHIDsForCommitMessage() {
-    return $this->getValue();
-  }
-
-  public function renderCommitMessageValue(array $handles) {
-    return $this->renderObjectList($handles);
-  }
-
-}