revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-10 00:42:41 +01:00
Code Issues Releases Wiki Activity

Continue reducing callsites to ArcanistDifferentialRevisionStatus in transactions

Browse source 
Summary: Ref T2543. Cleans up some more references to ArcanistDifferentialRevisionStatus, moving toward getting rid of it completely.

Test Plan: Planned changes, requested review, inspected the "close" one since it isn't trivial to trigger.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T2543

Differential Revision: https://secure.phabricator.com/D18408
This commit is contained in:
epriestley 2017-08-11 13:23:41 -07:00
parent 36197bf783
commit 77bf245637
3 changed files with 4 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/applications/differential/xaction/DifferentialRevisionCloseTransaction.php
View file

@ -35,15 +35,11 @@ final class DifferentialRevisionCloseTransaction
} }
public function applyInternalEffects($object, $value) { public function applyInternalEffects($object, $value) {
$was_accepted = $object->isAccepted();
$status_closed = ArcanistDifferentialRevisionStatus::CLOSED; $status_closed = ArcanistDifferentialRevisionStatus::CLOSED;
$status_accepted = ArcanistDifferentialRevisionStatus::ACCEPTED;
$old_status = $object->getStatus();
$object->setStatus($status_closed); $object->setStatus($status_closed);
$was_accepted = ($old_status == $status_accepted);
$object->setProperty( $object->setProperty(
DifferentialRevision::PROPERTY_CLOSED_FROM_ACCEPTED, DifferentialRevision::PROPERTY_CLOSED_FROM_ACCEPTED,
$was_accepted); $was_accepted);

3
src/applications/differential/xaction/DifferentialRevisionPlanChangesTransaction.php
View file

@ -46,8 +46,7 @@ final class DifferentialRevisionPlanChangesTransaction
} }
public function generateOldValue($object) { public function generateOldValue($object) {
$status_planned = ArcanistDifferentialRevisionStatus::CHANGES_PLANNED; return $object->isChangePlanned();
return ($object->getStatus() == $status_planned);
} }
public function applyInternalEffects($object, $value) { public function applyInternalEffects($object, $value) {

3
src/applications/differential/xaction/DifferentialRevisionRequestReviewTransaction.php
View file

@ -27,8 +27,7 @@ final class DifferentialRevisionRequestReviewTransaction
} }
public function generateOldValue($object) { public function generateOldValue($object) {
$status_review = ArcanistDifferentialRevisionStatus::NEEDS_REVIEW; return $object->isNeedsReview();
return ($object->getStatus() == $status_review);
} }
public function applyInternalEffects($object, $value) { public function applyInternalEffects($object, $value) {