Rename "DifferentialReviewer" to "DifferentialReviewerProxy"

Summary: Ref T10967. This makes room for a `DifferentialReviewer` object which can be a real storage table.

Test Plan: Grepped for `DifferentialReviewer`, browsed Differential.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10967

Differential Revision: https://secure.phabricator.com/D17041

src/__phutil_library_map__.php

@@ -495,9 +495,9 @@ phutil_register_library_map(array(
     'DifferentialResponsibleViewerFunctionDatasource' => 'applications/differential/typeahead/DifferentialResponsibleViewerFunctionDatasource.php',
     'DifferentialRevertPlanField' => 'applications/differential/customfield/DifferentialRevertPlanField.php',
     'DifferentialReviewedByField' => 'applications/differential/customfield/DifferentialReviewedByField.php',
-    'DifferentialReviewer' => 'applications/differential/storage/DifferentialReviewer.php',
     'DifferentialReviewerDatasource' => 'applications/differential/typeahead/DifferentialReviewerDatasource.php',
     'DifferentialReviewerForRevisionEdgeType' => 'applications/differential/edge/DifferentialReviewerForRevisionEdgeType.php',
+    'DifferentialReviewerProxy' => 'applications/differential/storage/DifferentialReviewerProxy.php',
     'DifferentialReviewerStatus' => 'applications/differential/constants/DifferentialReviewerStatus.php',
     'DifferentialReviewersAddBlockingReviewersHeraldAction' => 'applications/differential/herald/DifferentialReviewersAddBlockingReviewersHeraldAction.php',
     'DifferentialReviewersAddBlockingSelfHeraldAction' => 'applications/differential/herald/DifferentialReviewersAddBlockingSelfHeraldAction.php',
@@ -5125,9 +5125,9 @@ phutil_register_library_map(array(
     'DifferentialResponsibleViewerFunctionDatasource' => 'PhabricatorTypeaheadDatasource',
     'DifferentialRevertPlanField' => 'DifferentialStoredCustomField',
     'DifferentialReviewedByField' => 'DifferentialCoreCustomField',
-    'DifferentialReviewer' => 'Phobject',
     'DifferentialReviewerDatasource' => 'PhabricatorTypeaheadCompositeDatasource',
     'DifferentialReviewerForRevisionEdgeType' => 'PhabricatorEdgeType',
+    'DifferentialReviewerProxy' => 'Phobject',
     'DifferentialReviewerStatus' => 'Phobject',
     'DifferentialReviewersAddBlockingReviewersHeraldAction' => 'DifferentialReviewersHeraldAction',
     'DifferentialReviewersAddBlockingSelfHeraldAction' => 'DifferentialReviewersHeraldAction',

src/applications/differential/controller/DifferentialCommentSaveController.php

@@ -64,7 +64,7 @@ final class DifferentialCommentSaveController
       if (isset($current_reviewers[$reviewer_phid])) {
         continue;
       }
-      $reviewer = new DifferentialReviewer(
+      $reviewer = new DifferentialReviewerProxy(
         $reviewer_phid,
         array(
           'status' => DifferentialReviewerStatus::STATUS_ADDED,

src/applications/differential/customfield/DifferentialReviewersField.php

@@ -84,7 +84,7 @@ final class DifferentialReviewersField
     }
 
     foreach ($new_reviewers as $phid => $status) {
-      $new_reviewers[$phid] = new DifferentialReviewer(
+      $new_reviewers[$phid] = new DifferentialReviewerProxy(
         $phid,
         array(
           'status' => $status,

src/applications/differential/editor/DifferentialTransactionEditor.php

@@ -474,7 +474,7 @@ final class DifferentialTransactionEditor
 
             $owner_phid = $object->getAuthorPHID();
             if ($owner_phid) {
-              $reviewer = new DifferentialReviewer(
+              $reviewer = new DifferentialReviewerProxy(
                 $owner_phid,
                 array(
                   'status' => DifferentialReviewerStatus::STATUS_ADDED,

src/applications/differential/query/DifferentialRevisionQuery.php

@@ -1008,7 +1008,9 @@ final class DifferentialRevisionQuery
       $revision_edges = $edges[$revision->getPHID()][$edge_type];
       $reviewers = array();
       foreach ($revision_edges as $reviewer_phid => $edge) {
-        $reviewer = new DifferentialReviewer($reviewer_phid, $edge['data']);
+        $reviewer = new DifferentialReviewerProxy(
+          $reviewer_phid,
+          $edge['data']);
 
         if ($this->needReviewerAuthority) {
           if (!$viewer_phid) {

src/applications/differential/storage/DifferentialReviewerProxy.php

@@ -1,6 +1,6 @@
 <?php
 
-final class DifferentialReviewer extends Phobject {
+final class DifferentialReviewerProxy extends Phobject {
 
   private $reviewerPHID;
   private $status;

src/applications/differential/storage/DifferentialRevision.php

@@ -403,7 +403,7 @@ final class DifferentialRevision extends DifferentialDAO
   }
 
   public function attachReviewerStatus(array $reviewers) {
-    assert_instances_of($reviewers, 'DifferentialReviewer');
+    assert_instances_of($reviewers, 'DifferentialReviewerProxy');
 
     $this->reviewerStatus = $reviewers;
     return $this;

src/applications/differential/view/DifferentialReviewersView.php

@@ -7,7 +7,7 @@ final class DifferentialReviewersView extends AphrontView {
   private $diff;
 
   public function setReviewers(array $reviewers) {
-    assert_instances_of($reviewers, 'DifferentialReviewer');
+    assert_instances_of($reviewers, 'DifferentialReviewerProxy');
     $this->reviewers = $reviewers;
     return $this;
   }