revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-22 21:40:55 +01:00
Code Issues Releases Wiki Activity

Migrate RefCursor data to RefPosition table

Browse source 
Summary:
Ref T11823. This populates the new RefPosition table based on the existing RefCursor table, and deletes now-duplicate rows in the RefCursor table so the next change can add a unique key.

This change is not standalone, and there need to be separate code updates. I have a rough version of that written, but this migration needs to happen first to test it.

I'll hold this whole series of changes until after the release cut and until the code is updated.

Test Plan: Ran migration, spot-checked database tables. Saw redundant rows remove and correct-looking rows populated into the new RefPosition table.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T11823

Differential Revision: https://secure.phabricator.com/D18612
This commit is contained in:
epriestley 2017-09-15 08:21:15 -07:00
parent 9d5a2b3b4f
commit 782b18e7e2
1 changed files with 71 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

71
resources/sql/autopatches/20170915.ref.01.migrate.php Normal file
View file

@ -0,0 +1,71 @@
<?php
$table = new PhabricatorRepositoryRefCursor();
$conn = $table->establishConnection('w');
$map = array();
foreach (new LiskMigrationIterator($table) as $ref) {
$repository_phid = $ref->getRepositoryPHID();
$ref_type = $ref->getRefType();
$ref_hash = $ref->getRefNameHash();
$ref_key = "{$repository_phid}/{$ref_type}/{$ref_hash}";
if (!isset($map[$ref_key])) {
$map[$ref_key] = array(
'id' => $ref->getID(),
'type' => $ref_type,
'hash' => $ref_hash,
'repositoryPHID' => $repository_phid,
'positions' => array(),
);
}
// NOTE: When this migration runs, the table will have "commitIdentifier" and
// "isClosed" fields. Later, it won't. Since they'll be removed, we can't
// rely on being able to access them via the object. Instead, run a separate
// raw query to read them.
$row = queryfx_one(
$conn,
'SELECT commitIdentifier, isClosed FROM %T WHERE id = %d',
$ref->getTableName(),
$ref->getID());
$map[$ref_key]['positions'][] = array(
'identifier' => $row['commitIdentifier'],
'isClosed' => (int)$row['isClosed'],
);
}
// Now, write all the position rows.
$position_table = new PhabricatorRepositoryRefPosition();
foreach ($map as $ref_key => $spec) {
$id = $spec['id'];
foreach ($spec['positions'] as $position) {
queryfx(
$conn,
'INSERT IGNORE INTO %T (cursorID, commitIdentifier, isClosed)
VALUES (%d, %s, %d)',
$position_table->getTableName(),
$id,
$position['identifier'],
$position['isClosed']);
}
}
// Finally, delete all the redundant RefCursor rows (rows with the same name)
// so we can add proper unique keys in the next migration.
foreach ($map as $ref_key => $spec) {
queryfx(
$conn,
'DELETE FROM %T WHERE refType = %s
AND refNameHash = %s
AND repositoryPHID = %s
AND id != %d',
$table->getTableName(),
$spec['type'],
$spec['hash'],
$spec['repositoryPHID'],
$spec['id']);
}