revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-22 14:52:41 +01:00
Code Issues Releases Wiki Activity

Make ignored setup issues grey

Browse source 
Summary: When I ignore setup issues, I want them to look dealt with, and keep yellow for new ones. Also updated callout colors.

Test Plan: Ignored a number of issues.

Reviewers: epriestley, btrahan

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D6300
This commit is contained in:
Chad Little 2013-06-25 10:17:46 -07:00
parent 09ebd6617e
commit 78311f758d
3 changed files with 49 additions and 48 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

90
src/__celerity_resource_map__.php
View file

@ -3417,7 +3417,7 @@ celerity_register_resource_map(array(
), ),
'phabricator-standard-page-view' => 'phabricator-standard-page-view' =>
array( array(
'uri' => '/res/70fa2da4/rsrc/css/application/base/standard-page-view.css', 'uri' => '/res/c71cf9c7/rsrc/css/application/base/standard-page-view.css',
'type' => 'css', 'type' => 'css',
'requires' => 'requires' =>
array( array(
@ -4073,7 +4073,7 @@ celerity_register_resource_map(array(
), array( ), array(
'packages' => 'packages' =>
array( array(
'f154b8cb' => 'b939ab89' =>
array( array(
'name' => 'core.pkg.css', 'name' => 'core.pkg.css',
'symbols' => 'symbols' =>
@ -4121,7 +4121,7 @@ celerity_register_resource_map(array(
40 => 'phabricator-property-list-view-css', 40 => 'phabricator-property-list-view-css',
41 => 'phabricator-tag-view-css', 41 => 'phabricator-tag-view-css',
), ),
'uri' => '/res/pkg/f154b8cb/core.pkg.css', 'uri' => '/res/pkg/b939ab89/core.pkg.css',
'type' => 'css', 'type' => 'css',
), ),
'f2ad0683' => 'f2ad0683' =>
@ -4315,16 +4315,16 @@ celerity_register_resource_map(array(
'reverse' => 'reverse' =>
array( array(
'aphront-attached-file-view-css' => 'adc3c36d', 'aphront-attached-file-view-css' => 'adc3c36d',
'aphront-dialog-view-css' => 'f154b8cb', 'aphront-dialog-view-css' => 'b939ab89',
'aphront-error-view-css' => 'f154b8cb', 'aphront-error-view-css' => 'b939ab89',
'aphront-form-view-css' => 'f154b8cb', 'aphront-form-view-css' => 'b939ab89',
'aphront-list-filter-view-css' => 'f154b8cb', 'aphront-list-filter-view-css' => 'b939ab89',
'aphront-pager-view-css' => 'f154b8cb', 'aphront-pager-view-css' => 'b939ab89',
'aphront-panel-view-css' => 'f154b8cb', 'aphront-panel-view-css' => 'b939ab89',
'aphront-table-view-css' => 'f154b8cb', 'aphront-table-view-css' => 'b939ab89',
'aphront-tokenizer-control-css' => 'f154b8cb', 'aphront-tokenizer-control-css' => 'b939ab89',
'aphront-tooltip-css' => 'f154b8cb', 'aphront-tooltip-css' => 'b939ab89',
'aphront-typeahead-control-css' => 'f154b8cb', 'aphront-typeahead-control-css' => 'b939ab89',
'differential-changeset-view-css' => 'dd27a69b', 'differential-changeset-view-css' => 'dd27a69b',
'differential-core-view-css' => 'dd27a69b', 'differential-core-view-css' => 'dd27a69b',
'differential-inline-comment-editor' => '9488bb69', 'differential-inline-comment-editor' => '9488bb69',
@ -4338,7 +4338,7 @@ celerity_register_resource_map(array(
'differential-table-of-contents-css' => 'dd27a69b', 'differential-table-of-contents-css' => 'dd27a69b',
'diffusion-commit-view-css' => 'c8ce2d88', 'diffusion-commit-view-css' => 'c8ce2d88',
'diffusion-icons-css' => 'c8ce2d88', 'diffusion-icons-css' => 'c8ce2d88',
'global-drag-and-drop-css' => 'f154b8cb', 'global-drag-and-drop-css' => 'b939ab89',
'inline-comment-summary-css' => 'dd27a69b', 'inline-comment-summary-css' => 'dd27a69b',
'javelin-aphlict' => 'f2ad0683', 'javelin-aphlict' => 'f2ad0683',
'javelin-behavior' => 'a9f14d76', 'javelin-behavior' => 'a9f14d76',
@ -4412,55 +4412,55 @@ celerity_register_resource_map(array(
'javelin-util' => 'a9f14d76', 'javelin-util' => 'a9f14d76',
'javelin-vector' => 'a9f14d76', 'javelin-vector' => 'a9f14d76',
'javelin-workflow' => 'a9f14d76', 'javelin-workflow' => 'a9f14d76',
'lightbox-attachment-css' => 'f154b8cb', 'lightbox-attachment-css' => 'b939ab89',
'maniphest-task-summary-css' => 'adc3c36d', 'maniphest-task-summary-css' => 'adc3c36d',
'maniphest-transaction-detail-css' => 'adc3c36d', 'maniphest-transaction-detail-css' => 'adc3c36d',
'phabricator-action-list-view-css' => 'f154b8cb', 'phabricator-action-list-view-css' => 'b939ab89',
'phabricator-application-launch-view-css' => 'f154b8cb', 'phabricator-application-launch-view-css' => 'b939ab89',
'phabricator-busy' => 'f2ad0683', 'phabricator-busy' => 'f2ad0683',
'phabricator-content-source-view-css' => 'dd27a69b', 'phabricator-content-source-view-css' => 'dd27a69b',
'phabricator-core-css' => 'f154b8cb', 'phabricator-core-css' => 'b939ab89',
'phabricator-crumbs-view-css' => 'f154b8cb', 'phabricator-crumbs-view-css' => 'b939ab89',
'phabricator-drag-and-drop-file-upload' => '9488bb69', 'phabricator-drag-and-drop-file-upload' => '9488bb69',
'phabricator-dropdown-menu' => 'f2ad0683', 'phabricator-dropdown-menu' => 'f2ad0683',
'phabricator-file-upload' => 'f2ad0683', 'phabricator-file-upload' => 'f2ad0683',
'phabricator-filetree-view-css' => 'f154b8cb', 'phabricator-filetree-view-css' => 'b939ab89',
'phabricator-flag-css' => 'f154b8cb', 'phabricator-flag-css' => 'b939ab89',
'phabricator-form-view-css' => 'f154b8cb', 'phabricator-form-view-css' => 'b939ab89',
'phabricator-header-view-css' => 'f154b8cb', 'phabricator-header-view-css' => 'b939ab89',
'phabricator-hovercard' => 'f2ad0683', 'phabricator-hovercard' => 'f2ad0683',
'phabricator-jump-nav' => 'f154b8cb', 'phabricator-jump-nav' => 'b939ab89',
'phabricator-keyboard-shortcut' => 'f2ad0683', 'phabricator-keyboard-shortcut' => 'f2ad0683',
'phabricator-keyboard-shortcut-manager' => 'f2ad0683', 'phabricator-keyboard-shortcut-manager' => 'f2ad0683',
'phabricator-main-menu-view' => 'f154b8cb', 'phabricator-main-menu-view' => 'b939ab89',
'phabricator-menu-item' => 'f2ad0683', 'phabricator-menu-item' => 'f2ad0683',
'phabricator-nav-view-css' => 'f154b8cb', 'phabricator-nav-view-css' => 'b939ab89',
'phabricator-notification' => 'f2ad0683', 'phabricator-notification' => 'f2ad0683',
'phabricator-notification-css' => 'f154b8cb', 'phabricator-notification-css' => 'b939ab89',
'phabricator-notification-menu-css' => 'f154b8cb', 'phabricator-notification-menu-css' => 'b939ab89',
'phabricator-object-item-list-view-css' => 'f154b8cb', 'phabricator-object-item-list-view-css' => 'b939ab89',
'phabricator-object-selector-css' => 'dd27a69b', 'phabricator-object-selector-css' => 'dd27a69b',
'phabricator-phtize' => 'f2ad0683', 'phabricator-phtize' => 'f2ad0683',
'phabricator-prefab' => 'f2ad0683', 'phabricator-prefab' => 'f2ad0683',
'phabricator-project-tag-css' => 'adc3c36d', 'phabricator-project-tag-css' => 'adc3c36d',
'phabricator-property-list-view-css' => 'f154b8cb', 'phabricator-property-list-view-css' => 'b939ab89',
'phabricator-remarkup-css' => 'f154b8cb', 'phabricator-remarkup-css' => 'b939ab89',
'phabricator-shaped-request' => '9488bb69', 'phabricator-shaped-request' => '9488bb69',
'phabricator-side-menu-view-css' => 'f154b8cb', 'phabricator-side-menu-view-css' => 'b939ab89',
'phabricator-standard-page-view' => 'f154b8cb', 'phabricator-standard-page-view' => 'b939ab89',
'phabricator-tag-view-css' => 'f154b8cb', 'phabricator-tag-view-css' => 'b939ab89',
'phabricator-textareautils' => 'f2ad0683', 'phabricator-textareautils' => 'f2ad0683',
'phabricator-tooltip' => 'f2ad0683', 'phabricator-tooltip' => 'f2ad0683',
'phabricator-transaction-view-css' => 'f154b8cb', 'phabricator-transaction-view-css' => 'b939ab89',
'phabricator-zindex-css' => 'f154b8cb', 'phabricator-zindex-css' => 'b939ab89',
'phui-button-css' => 'f154b8cb', 'phui-button-css' => 'b939ab89',
'phui-form-css' => 'f154b8cb', 'phui-form-css' => 'b939ab89',
'phui-icon-view-css' => 'f154b8cb', 'phui-icon-view-css' => 'b939ab89',
'phui-spacing-css' => 'f154b8cb', 'phui-spacing-css' => 'b939ab89',
'sprite-apps-large-css' => 'f154b8cb', 'sprite-apps-large-css' => 'b939ab89',
'sprite-gradient-css' => 'f154b8cb', 'sprite-gradient-css' => 'b939ab89',
'sprite-icons-css' => 'f154b8cb', 'sprite-icons-css' => 'b939ab89',
'sprite-menu-css' => 'f154b8cb', 'sprite-menu-css' => 'b939ab89',
'syntax-highlighting-css' => 'f154b8cb', 'syntax-highlighting-css' => 'b939ab89',
), ),
)); ));

3
src/applications/config/controller/PhabricatorConfigIssueListController.php
View file

@ -56,7 +56,6 @@ final class PhabricatorConfigIssueListController
$item = id(new PhabricatorObjectItemView()) $item = id(new PhabricatorObjectItemView())
->setHeader($issue->getName()) ->setHeader($issue->getName())
->setHref($href) ->setHref($href)
->setBarColor('yellow')
->addAttribute($issue->getSummary()); ->addAttribute($issue->getSummary());
if (!$issue->getIsIgnored()) { if (!$issue->getIsIgnored()) {
$item->addIcon('warning', pht('Setup Warning')); $item->addIcon('warning', pht('Setup Warning'));
@ -65,6 +64,7 @@ final class PhabricatorConfigIssueListController
array('href' => '/config/ignore/'.$issue->getIssueKey().'/', array('href' => '/config/ignore/'.$issue->getIssueKey().'/',
'sigil' => 'workflow'), 'sigil' => 'workflow'),
pht('Ignore')); pht('Ignore'));
$item->setBarColor('yellow');
$item->addAttribute($link); $item->addAttribute($link);
$list->addItem($item); $list->addItem($item);
} else { } else {
@ -75,6 +75,7 @@ final class PhabricatorConfigIssueListController
'sigil' => 'workflow'), 'sigil' => 'workflow'),
pht('Unignore')); pht('Unignore'));
$item->addAttribute($link); $item->addAttribute($link);
$item->setBarColor('none');
$ignored_items[] = $item; $ignored_items[] = $item;
} }
} }

4
webroot/rsrc/css/application/base/standard-page-view.css
View file

@ -96,6 +96,6 @@ a.handle-disabled {
.setup-warning-callout { .setup-warning-callout {
position: relative; position: relative;
padding: 0.75em 1em; padding: 8px 16px;
background: #ffffbb; background: {$lightyellow};
} }