Make ignored setup issues grey

Summary: When I ignore setup issues, I want them to look dealt with, and keep yellow for new ones. Also updated callout colors.

Test Plan: Ignored a number of issues.

Reviewers: epriestley, btrahan

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D6300

src/__celerity_resource_map__.php

@@ -3417,7 +3417,7 @@ celerity_register_resource_map(array(
   ),
   'phabricator-standard-page-view' =>
   array(
-    'uri' => '/res/70fa2da4/rsrc/css/application/base/standard-page-view.css',
+    'uri' => '/res/c71cf9c7/rsrc/css/application/base/standard-page-view.css',
     'type' => 'css',
     'requires' =>
     array(
@@ -4073,7 +4073,7 @@ celerity_register_resource_map(array(
 ), array(
   'packages' =>
   array(
-    'f154b8cb' =>
+    'b939ab89' =>
     array(
       'name' => 'core.pkg.css',
       'symbols' =>
@@ -4121,7 +4121,7 @@ celerity_register_resource_map(array(
         40 => 'phabricator-property-list-view-css',
         41 => 'phabricator-tag-view-css',
       ),
-      'uri' => '/res/pkg/f154b8cb/core.pkg.css',
+      'uri' => '/res/pkg/b939ab89/core.pkg.css',
       'type' => 'css',
     ),
     'f2ad0683' =>
@@ -4315,16 +4315,16 @@ celerity_register_resource_map(array(
   'reverse' =>
   array(
     'aphront-attached-file-view-css' => 'adc3c36d',
-    'aphront-dialog-view-css' => 'f154b8cb',
-    'aphront-error-view-css' => 'f154b8cb',
-    'aphront-form-view-css' => 'f154b8cb',
-    'aphront-list-filter-view-css' => 'f154b8cb',
-    'aphront-pager-view-css' => 'f154b8cb',
-    'aphront-panel-view-css' => 'f154b8cb',
-    'aphront-table-view-css' => 'f154b8cb',
-    'aphront-tokenizer-control-css' => 'f154b8cb',
-    'aphront-tooltip-css' => 'f154b8cb',
-    'aphront-typeahead-control-css' => 'f154b8cb',
+    'aphront-dialog-view-css' => 'b939ab89',
+    'aphront-error-view-css' => 'b939ab89',
+    'aphront-form-view-css' => 'b939ab89',
+    'aphront-list-filter-view-css' => 'b939ab89',
+    'aphront-pager-view-css' => 'b939ab89',
+    'aphront-panel-view-css' => 'b939ab89',
+    'aphront-table-view-css' => 'b939ab89',
+    'aphront-tokenizer-control-css' => 'b939ab89',
+    'aphront-tooltip-css' => 'b939ab89',
+    'aphront-typeahead-control-css' => 'b939ab89',
     'differential-changeset-view-css' => 'dd27a69b',
     'differential-core-view-css' => 'dd27a69b',
     'differential-inline-comment-editor' => '9488bb69',
@@ -4338,7 +4338,7 @@ celerity_register_resource_map(array(
     'differential-table-of-contents-css' => 'dd27a69b',
     'diffusion-commit-view-css' => 'c8ce2d88',
     'diffusion-icons-css' => 'c8ce2d88',
-    'global-drag-and-drop-css' => 'f154b8cb',
+    'global-drag-and-drop-css' => 'b939ab89',
     'inline-comment-summary-css' => 'dd27a69b',
     'javelin-aphlict' => 'f2ad0683',
     'javelin-behavior' => 'a9f14d76',
@@ -4412,55 +4412,55 @@ celerity_register_resource_map(array(
     'javelin-util' => 'a9f14d76',
     'javelin-vector' => 'a9f14d76',
     'javelin-workflow' => 'a9f14d76',
-    'lightbox-attachment-css' => 'f154b8cb',
+    'lightbox-attachment-css' => 'b939ab89',
     'maniphest-task-summary-css' => 'adc3c36d',
     'maniphest-transaction-detail-css' => 'adc3c36d',
-    'phabricator-action-list-view-css' => 'f154b8cb',
-    'phabricator-application-launch-view-css' => 'f154b8cb',
+    'phabricator-action-list-view-css' => 'b939ab89',
+    'phabricator-application-launch-view-css' => 'b939ab89',
     'phabricator-busy' => 'f2ad0683',
     'phabricator-content-source-view-css' => 'dd27a69b',
-    'phabricator-core-css' => 'f154b8cb',
-    'phabricator-crumbs-view-css' => 'f154b8cb',
+    'phabricator-core-css' => 'b939ab89',
+    'phabricator-crumbs-view-css' => 'b939ab89',
     'phabricator-drag-and-drop-file-upload' => '9488bb69',
     'phabricator-dropdown-menu' => 'f2ad0683',
     'phabricator-file-upload' => 'f2ad0683',
-    'phabricator-filetree-view-css' => 'f154b8cb',
-    'phabricator-flag-css' => 'f154b8cb',
-    'phabricator-form-view-css' => 'f154b8cb',
-    'phabricator-header-view-css' => 'f154b8cb',
+    'phabricator-filetree-view-css' => 'b939ab89',
+    'phabricator-flag-css' => 'b939ab89',
+    'phabricator-form-view-css' => 'b939ab89',
+    'phabricator-header-view-css' => 'b939ab89',
     'phabricator-hovercard' => 'f2ad0683',
-    'phabricator-jump-nav' => 'f154b8cb',
+    'phabricator-jump-nav' => 'b939ab89',
     'phabricator-keyboard-shortcut' => 'f2ad0683',
     'phabricator-keyboard-shortcut-manager' => 'f2ad0683',
-    'phabricator-main-menu-view' => 'f154b8cb',
+    'phabricator-main-menu-view' => 'b939ab89',
     'phabricator-menu-item' => 'f2ad0683',
-    'phabricator-nav-view-css' => 'f154b8cb',
+    'phabricator-nav-view-css' => 'b939ab89',
     'phabricator-notification' => 'f2ad0683',
-    'phabricator-notification-css' => 'f154b8cb',
-    'phabricator-notification-menu-css' => 'f154b8cb',
-    'phabricator-object-item-list-view-css' => 'f154b8cb',
+    'phabricator-notification-css' => 'b939ab89',
+    'phabricator-notification-menu-css' => 'b939ab89',
+    'phabricator-object-item-list-view-css' => 'b939ab89',
     'phabricator-object-selector-css' => 'dd27a69b',
     'phabricator-phtize' => 'f2ad0683',
     'phabricator-prefab' => 'f2ad0683',
     'phabricator-project-tag-css' => 'adc3c36d',
-    'phabricator-property-list-view-css' => 'f154b8cb',
-    'phabricator-remarkup-css' => 'f154b8cb',
+    'phabricator-property-list-view-css' => 'b939ab89',
+    'phabricator-remarkup-css' => 'b939ab89',
     'phabricator-shaped-request' => '9488bb69',
-    'phabricator-side-menu-view-css' => 'f154b8cb',
-    'phabricator-standard-page-view' => 'f154b8cb',
-    'phabricator-tag-view-css' => 'f154b8cb',
+    'phabricator-side-menu-view-css' => 'b939ab89',
+    'phabricator-standard-page-view' => 'b939ab89',
+    'phabricator-tag-view-css' => 'b939ab89',
     'phabricator-textareautils' => 'f2ad0683',
     'phabricator-tooltip' => 'f2ad0683',
-    'phabricator-transaction-view-css' => 'f154b8cb',
-    'phabricator-zindex-css' => 'f154b8cb',
-    'phui-button-css' => 'f154b8cb',
-    'phui-form-css' => 'f154b8cb',
-    'phui-icon-view-css' => 'f154b8cb',
-    'phui-spacing-css' => 'f154b8cb',
-    'sprite-apps-large-css' => 'f154b8cb',
-    'sprite-gradient-css' => 'f154b8cb',
-    'sprite-icons-css' => 'f154b8cb',
-    'sprite-menu-css' => 'f154b8cb',
-    'syntax-highlighting-css' => 'f154b8cb',
+    'phabricator-transaction-view-css' => 'b939ab89',
+    'phabricator-zindex-css' => 'b939ab89',
+    'phui-button-css' => 'b939ab89',
+    'phui-form-css' => 'b939ab89',
+    'phui-icon-view-css' => 'b939ab89',
+    'phui-spacing-css' => 'b939ab89',
+    'sprite-apps-large-css' => 'b939ab89',
+    'sprite-gradient-css' => 'b939ab89',
+    'sprite-icons-css' => 'b939ab89',
+    'sprite-menu-css' => 'b939ab89',
+    'syntax-highlighting-css' => 'b939ab89',
   ),
 ));

src/applications/config/controller/PhabricatorConfigIssueListController.php

@@ -56,7 +56,6 @@ final class PhabricatorConfigIssueListController
         $item = id(new PhabricatorObjectItemView())
           ->setHeader($issue->getName())
           ->setHref($href)
-          ->setBarColor('yellow')
           ->addAttribute($issue->getSummary());
       if (!$issue->getIsIgnored()) {
         $item->addIcon('warning', pht('Setup Warning'));
@@ -65,6 +64,7 @@ final class PhabricatorConfigIssueListController
                  array('href'  => '/config/ignore/'.$issue->getIssueKey().'/',
                        'sigil' => 'workflow'),
                  pht('Ignore'));
+        $item->setBarColor('yellow');
         $item->addAttribute($link);
         $list->addItem($item);
       } else {
@@ -75,6 +75,7 @@ final class PhabricatorConfigIssueListController
                        'sigil' => 'workflow'),
                  pht('Unignore'));
         $item->addAttribute($link);
+        $item->setBarColor('none');
         $ignored_items[] = $item;
       }
     }

webroot/rsrc/css/application/base/standard-page-view.css

@@ -96,6 +96,6 @@ a.handle-disabled {
 
 .setup-warning-callout {
   position: relative;
-  padding: 0.75em 1em;
-  background: #ffffbb;
+  padding: 8px 16px;
+  background: {$lightyellow};
 }