From 78b19a43e143b76c0ac535f38f7b789d4bfd3865 Mon Sep 17 00:00:00 2001 From: Joshua Spence Date: Wed, 7 Jan 2015 07:34:35 +1100 Subject: [PATCH] Fix method visibility for `PhabricatorApplicationTransactionEditor` methods Summary: Ref T6822. Test Plan: Visual inspection. These methods are only called from within the `PhabricatorApplicationTransactionEditor` class. Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6822 Differential Revision: https://secure.phabricator.com/D11244 --- src/applications/releeph/editor/ReleephProductEditor.php | 6 +++--- .../releeph/editor/ReleephRequestTransactionalEditor.php | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/applications/releeph/editor/ReleephProductEditor.php b/src/applications/releeph/editor/ReleephProductEditor.php index 9ecf350563..4c3d69c97b 100644 --- a/src/applications/releeph/editor/ReleephProductEditor.php +++ b/src/applications/releeph/editor/ReleephProductEditor.php @@ -19,7 +19,7 @@ final class ReleephProductEditor return $types; } - public function getCustomTransactionOldValue( + protected function getCustomTransactionOldValue( PhabricatorLiskDAO $object, PhabricatorApplicationTransaction $xaction) { @@ -29,7 +29,7 @@ final class ReleephProductEditor } } - public function getCustomTransactionNewValue( + protected function getCustomTransactionNewValue( PhabricatorLiskDAO $object, PhabricatorApplicationTransaction $xaction) { @@ -39,7 +39,7 @@ final class ReleephProductEditor } } - public function applyCustomInternalTransaction( + protected function applyCustomInternalTransaction( PhabricatorLiskDAO $object, PhabricatorApplicationTransaction $xaction) { $new = $xaction->getNewValue(); diff --git a/src/applications/releeph/editor/ReleephRequestTransactionalEditor.php b/src/applications/releeph/editor/ReleephRequestTransactionalEditor.php index 7a6124797c..9e4c0083d2 100644 --- a/src/applications/releeph/editor/ReleephRequestTransactionalEditor.php +++ b/src/applications/releeph/editor/ReleephRequestTransactionalEditor.php @@ -26,7 +26,7 @@ final class ReleephRequestTransactionalEditor return $types; } - public function getCustomTransactionOldValue( + protected function getCustomTransactionOldValue( PhabricatorLiskDAO $object, PhabricatorApplicationTransaction $xaction) { @@ -58,7 +58,7 @@ final class ReleephRequestTransactionalEditor } } - public function getCustomTransactionNewValue( + protected function getCustomTransactionNewValue( PhabricatorLiskDAO $object, PhabricatorApplicationTransaction $xaction) { @@ -74,7 +74,7 @@ final class ReleephRequestTransactionalEditor } } - public function applyCustomInternalTransaction( + protected function applyCustomInternalTransaction( PhabricatorLiskDAO $object, PhabricatorApplicationTransaction $xaction) {