Slightly improve Maniphest documentation.

src/__phutil_library_map__.php

@@ -261,6 +261,7 @@ phutil_register_library_map(array(
     'LiskIsolationTestCase' => 'storage/lisk/dao/__tests__',
     'LiskIsolationTestDAO' => 'storage/lisk/dao/__tests__',
     'LiskIsolationTestDAOException' => 'storage/lisk/dao/__tests__',
+    'ManiphestConstants' => 'applications/maniphest/constants/base',
     'ManiphestController' => 'applications/maniphest/controller/base',
     'ManiphestDAO' => 'applications/maniphest/storage/base',
     'ManiphestReplyHandler' => 'applications/maniphest/replyhandler',
@@ -283,6 +284,7 @@ phutil_register_library_map(array(
     'ManiphestTransactionPreviewController' => 'applications/maniphest/controller/transactionpreview',
     'ManiphestTransactionSaveController' => 'applications/maniphest/controller/transactionsave',
     'ManiphestTransactionType' => 'applications/maniphest/constants/transactiontype',
+    'ManiphestView' => 'applications/maniphest/view/base',
     'Phabricator404Controller' => 'applications/base/controller/404',
     'PhabricatorAuthController' => 'applications/auth/controller/base',
     'PhabricatorConduitAPIController' => 'applications/conduit/controller/api',
@@ -766,14 +768,19 @@ phutil_register_library_map(array(
     'ManiphestTaskDetailController' => 'ManiphestController',
     'ManiphestTaskEditController' => 'ManiphestController',
     'ManiphestTaskListController' => 'ManiphestController',
-    'ManiphestTaskListView' => 'AphrontView',
+    'ManiphestTaskListView' => 'ManiphestView',
+    'ManiphestTaskOwner' => 'ManiphestConstants',
+    'ManiphestTaskPriority' => 'ManiphestConstants',
     'ManiphestTaskProject' => 'ManiphestDAO',
-    'ManiphestTaskSummaryView' => 'AphrontView',
+    'ManiphestTaskStatus' => 'ManiphestConstants',
+    'ManiphestTaskSummaryView' => 'ManiphestView',
     'ManiphestTransaction' => 'ManiphestDAO',
-    'ManiphestTransactionDetailView' => 'AphrontView',
-    'ManiphestTransactionListView' => 'AphrontView',
+    'ManiphestTransactionDetailView' => 'ManiphestView',
+    'ManiphestTransactionListView' => 'ManiphestView',
     'ManiphestTransactionPreviewController' => 'ManiphestController',
     'ManiphestTransactionSaveController' => 'ManiphestController',
+    'ManiphestTransactionType' => 'ManiphestConstants',
+    'ManiphestView' => 'AphrontView',
     'Phabricator404Controller' => 'PhabricatorController',
     'PhabricatorAuthController' => 'PhabricatorController',
     'PhabricatorConduitAPIController' => 'PhabricatorConduitController',

src/applications/maniphest/constants/base/ManiphestConstants.php

@@ -0,0 +1,24 @@
+<?php
+
+/*
+ * Copyright 2011 Facebook, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+/**
+ * @group maniphest
+ */
+class ManiphestConstants {
+
+}

src/applications/maniphest/constants/base/__init__.php

@@ -0,0 +1,10 @@
+<?php
+/**
+ * This file is automatically generated. Lint this module to rebuild it.
+ * @generated
+ */
+
+
+
+
+phutil_require_source('ManiphestConstants.php');

src/applications/maniphest/constants/owner/ManiphestTaskOwner.php

@@ -16,7 +16,10 @@
  * limitations under the License.
  */
 
-final class ManiphestTaskOwner {
+/**
+ * @group maniphest
+ */
+final class ManiphestTaskOwner extends ManiphestConstants {
 
   const OWNER_UP_FOR_GRABS = 'PHID-!!!!-UP-FOR-GRABS';
 

src/applications/maniphest/constants/owner/__init__.php

@@ -6,5 +6,7 @@
 
 
 
+phutil_require_module('phabricator', 'applications/maniphest/constants/base');
+
 
 phutil_require_source('ManiphestTaskOwner.php');

src/applications/maniphest/constants/priority/ManiphestTaskPriority.php

@@ -16,7 +16,10 @@
  * limitations under the License.
  */
 
-final class ManiphestTaskPriority {
+/**
+ * @group maniphest
+ */
+final class ManiphestTaskPriority extends ManiphestConstants {
 
   const PRIORITY_UNBREAK_NOW  = 100;
   const PRIORITY_TRIAGE       = 90;

src/applications/maniphest/constants/priority/__init__.php

@@ -6,6 +6,8 @@
 
 
 
+phutil_require_module('phabricator', 'applications/maniphest/constants/base');
+
 phutil_require_module('phutil', 'utils');
 
 

src/applications/maniphest/constants/status/ManiphestTaskStatus.php

@@ -16,7 +16,10 @@
  * limitations under the License.
  */
 
-final class ManiphestTaskStatus {
+/**
+ * @group maniphest
+ */
+final class ManiphestTaskStatus extends ManiphestConstants {
 
   const STATUS_OPEN               = 0;
   const STATUS_CLOSED_RESOLVED    = 1;

src/applications/maniphest/constants/status/__init__.php

@@ -6,6 +6,8 @@
 
 
 
+phutil_require_module('phabricator', 'applications/maniphest/constants/base');
+
 phutil_require_module('phutil', 'utils');
 
 

src/applications/maniphest/constants/transactiontype/ManiphestTransactionType.php

@@ -16,7 +16,10 @@
  * limitations under the License.
  */
 
-final class ManiphestTransactionType {
+/**
+ * @group maniphest
+ */
+final class ManiphestTransactionType extends ManiphestConstants {
 
   const TYPE_NONE         = 'comment';
   const TYPE_STATUS       = 'status';

src/applications/maniphest/constants/transactiontype/__init__.php

@@ -6,5 +6,7 @@
 
 
 
+phutil_require_module('phabricator', 'applications/maniphest/constants/base');
+
 
 phutil_require_source('ManiphestTransactionType.php');

src/applications/maniphest/controller/base/ManiphestController.php

@@ -16,6 +16,9 @@
  * limitations under the License.
  */
 
+/**
+ * @group maniphest
+ */
 abstract class ManiphestController extends PhabricatorController {
 
   public function buildStandardPageResponse($view, array $data) {

src/applications/maniphest/controller/descriptionchange/ManiphestTaskDescriptionChangeController.php

@@ -16,6 +16,9 @@
  * limitations under the License.
  */
 
+/**
+ * @group maniphest
+ */
 class ManiphestTaskDescriptionChangeController extends ManiphestController {
 
   private $transactionID;

src/applications/maniphest/controller/taskdetail/ManiphestTaskDetailController.php

@@ -16,6 +16,9 @@
  * limitations under the License.
  */
 
+/**
+ * @group maniphest
+ */
 class ManiphestTaskDetailController extends ManiphestController {
 
   private $id;

src/applications/maniphest/controller/taskedit/ManiphestTaskEditController.php

@@ -16,6 +16,9 @@
  * limitations under the License.
  */
 
+/**
+ * @group maniphest
+ */
 class ManiphestTaskEditController extends ManiphestController {
 
   private $id;

src/applications/maniphest/controller/tasklist/ManiphestTaskListController.php

@@ -16,6 +16,9 @@
  * limitations under the License.
  */
 
+/**
+ * @group maniphest
+ */
 class ManiphestTaskListController extends ManiphestController {
 
   const DEFAULT_PAGE_SIZE = 1000;

src/applications/maniphest/controller/transactionpreview/ManiphestTransactionPreviewController.php

@@ -16,6 +16,9 @@
  * limitations under the License.
  */
 
+/**
+ * @group maniphest
+ */
 class ManiphestTransactionPreviewController extends ManiphestController {
 
   private $id;

src/applications/maniphest/controller/transactionsave/ManiphestTransactionSaveController.php

@@ -16,6 +16,9 @@
  * limitations under the License.
  */
 
+/**
+ * @group maniphest
+ */
 class ManiphestTransactionSaveController extends ManiphestController {
 
   public function processRequest() {

src/applications/maniphest/editor/transaction/ManiphestTransactionEditor.php

@@ -16,6 +16,9 @@
  * limitations under the License.
  */
 
+/**
+ * @group maniphest
+ */
 class ManiphestTransactionEditor {
 
   private $parentMessageID;

src/applications/maniphest/query/ManiphestTaskQuery.php

@@ -19,6 +19,8 @@
 /**
  * Query tasks by specific criteria. This class uses the higher-performance
  * but less-general Maniphest indexes to satisfy queries.
+ *
+ * @group maniphest
  */
 final class ManiphestTaskQuery {
 

src/applications/maniphest/replyhandler/ManiphestReplyHandler.php

@@ -16,6 +16,9 @@
  * limitations under the License.
  */
 
+/**
+ * @group maniphest
+ */
 class ManiphestReplyHandler extends PhabricatorMailReplyHandler {
 
   public function validateMailReceiver($mail_receiver) {

src/applications/maniphest/storage/base/ManiphestDAO.php

@@ -16,6 +16,9 @@
  * limitations under the License.
  */
 
+/**
+ * @group maniphest
+ */
 class ManiphestDAO extends PhabricatorLiskDAO {
 
   public function getApplicationName() {

src/applications/maniphest/storage/task/ManiphestTask.php

@@ -16,6 +16,9 @@
  * limitations under the License.
  */
 
+/**
+ * @group maniphest
+ */
 class ManiphestTask extends ManiphestDAO {
 
   protected $phid;

src/applications/maniphest/storage/transaction/ManiphestTransaction.php

@@ -16,6 +16,9 @@
  * limitations under the License.
  */
 
+/**
+ * @group maniphest
+ */
 class ManiphestTransaction extends ManiphestDAO {
 
   protected $taskID;

src/applications/maniphest/view/base/ManiphestView.php

@@ -0,0 +1,24 @@
+<?php
+
+/*
+ * Copyright 2011 Facebook, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+/**
+ * @group maniphest
+ */
+abstract class ManiphestView extends AphrontView {
+
+}

src/applications/maniphest/view/base/__init__.php

@@ -0,0 +1,12 @@
+<?php
+/**
+ * This file is automatically generated. Lint this module to rebuild it.
+ * @generated
+ */
+
+
+
+phutil_require_module('phabricator', 'view/base');
+
+
+phutil_require_source('ManiphestView.php');

src/applications/maniphest/view/tasklist/ManiphestTaskListView.php

@@ -16,7 +16,10 @@
  * limitations under the License.
  */
 
-class ManiphestTaskListView extends AphrontView {
+/**
+ * @group maniphest
+ */
+class ManiphestTaskListView extends ManiphestView {
 
   private $tasks;
   private $handles;

src/applications/maniphest/view/tasklist/__init__.php

@@ -6,8 +6,8 @@
 
 
 
+phutil_require_module('phabricator', 'applications/maniphest/view/base');
 phutil_require_module('phabricator', 'applications/maniphest/view/tasksummary');
-phutil_require_module('phabricator', 'view/base');
 
 
 phutil_require_source('ManiphestTaskListView.php');

src/applications/maniphest/view/tasksummary/ManiphestTaskSummaryView.php

@@ -16,7 +16,10 @@
  * limitations under the License.
  */
 
-class ManiphestTaskSummaryView extends AphrontView {
+/**
+ * @group maniphest
+ */
+class ManiphestTaskSummaryView extends ManiphestView {
 
   private $task;
   private $handles;

src/applications/maniphest/view/tasksummary/__init__.php

@@ -8,8 +8,8 @@
 
 phutil_require_module('phabricator', 'applications/maniphest/constants/priority');
 phutil_require_module('phabricator', 'applications/maniphest/constants/status');
+phutil_require_module('phabricator', 'applications/maniphest/view/base');
 phutil_require_module('phabricator', 'infrastructure/celerity/api');
-phutil_require_module('phabricator', 'view/base');
 phutil_require_module('phabricator', 'view/utils');
 
 phutil_require_module('phutil', 'markup');

src/applications/maniphest/view/transactiondetail/ManiphestTransactionDetailView.php

@@ -16,7 +16,10 @@
  * limitations under the License.
  */
 
-class ManiphestTransactionDetailView extends AphrontView {
+/**
+ * @group maniphest
+ */
+class ManiphestTransactionDetailView extends ManiphestView {
 
   private $transactions;
   private $handles;

src/applications/maniphest/view/transactiondetail/__init__.php

@@ -9,12 +9,12 @@
 phutil_require_module('phabricator', 'applications/maniphest/constants/priority');
 phutil_require_module('phabricator', 'applications/maniphest/constants/status');
 phutil_require_module('phabricator', 'applications/maniphest/constants/transactiontype');
+phutil_require_module('phabricator', 'applications/maniphest/view/base');
 phutil_require_module('phabricator', 'applications/phid/constants');
 phutil_require_module('phabricator', 'infrastructure/celerity/api');
 phutil_require_module('phabricator', 'infrastructure/env');
 phutil_require_module('phabricator', 'infrastructure/javelin/api');
 phutil_require_module('phabricator', 'infrastructure/javelin/markup');
-phutil_require_module('phabricator', 'view/base');
 phutil_require_module('phabricator', 'view/utils');
 
 phutil_require_module('phutil', 'markup');

src/applications/maniphest/view/transactionlist/ManiphestTransactionListView.php

@@ -16,7 +16,10 @@
  * limitations under the License.
  */
 
-class ManiphestTransactionListView extends AphrontView {
+/**
+ * @group maniphest
+ */
+class ManiphestTransactionListView extends ManiphestView {
 
   private $transactions;
   private $handles;

src/applications/maniphest/view/transactionlist/__init__.php

@@ -6,8 +6,8 @@
 
 
 
+phutil_require_module('phabricator', 'applications/maniphest/view/base');
 phutil_require_module('phabricator', 'applications/maniphest/view/transactiondetail');
-phutil_require_module('phabricator', 'view/base');
 
 
 phutil_require_source('ManiphestTransactionListView.php');

src/docs/userguide/remarkup.diviner

@@ -1,7 +1,7 @@
 @title Remarkup Reference
 @group userguide
 
-Explains how to make bold text, etc. This makes your words louder so you can win
+Explains how to make bold text; this makes your words louder so you can win
 arguments.
 
 = Overview =