From 78cbfc3a0217d4794bdd77a2c85209016d213d10 Mon Sep 17 00:00:00 2001
From: Chad Little <chad@chadsdomain.com>
Date: Fri, 6 Sep 2013 10:42:44 -0700
Subject: [PATCH] Fix extra divs in PHUIBoxView

Summary: This moves the outer classes to the outmost div

Test Plan: Reviewed a few PHUIBox pages

Reviewers: epriestley

Reviewed By: epriestley

CC: Korvin, aran

Differential Revision: https://secure.phabricator.com/D6902
---
 src/view/phui/PHUIBoxView.php | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/src/view/phui/PHUIBoxView.php b/src/view/phui/PHUIBoxView.php
index cc0771a161..86e6d3226a 100644
--- a/src/view/phui/PHUIBoxView.php
+++ b/src/view/phui/PHUIBoxView.php
@@ -27,10 +27,7 @@ final class PHUIBoxView extends AphrontTagView {
     return $this;
   }
 
-  public function getTagContent() {
-
-    require_celerity_resource('phui-box-css');
-
+  protected function getTagAttributes() {
     $outer_classes = array();
     $outer_classes[] = 'phui-box';
     if ($this->shadow) {
@@ -43,24 +40,27 @@ final class PHUIBoxView extends AphrontTagView {
       $outer_classes[] = $margin;
     }
 
+    return array('class' => $outer_classes);
+  }
+
+  public function getTagName() {
+    return 'div';
+  }
+
+  public function getTagContent() {
+    require_celerity_resource('phui-box-css');
+
     $inner_classes = array();
     $inner_classes[] = 'phui-box-inner';
     foreach ($this->padding as $padding) {
       $inner_classes[] = $padding;
     }
 
-    $inner = phutil_tag(
+    return phutil_tag(
       'div',
         array(
           'class' => implode(' ', $inner_classes)
         ),
         $this->renderChildren());
-
-    return phutil_tag(
-      'div',
-        array(
-          'class' => implode(' ', $outer_classes)
-        ),
-        $inner);
   }
 }