From 79e36dc7fa39a050c7d8d708684974de0d39046b Mon Sep 17 00:00:00 2001 From: epriestley Date: Fri, 22 Mar 2019 06:41:00 -0700 Subject: [PATCH] Explain the relationship between "Runnable" and "Restartable" more clearly in Build Plans Summary: See PHI1153. The "Runnable" and "Restartable" behaviors interact (to click "restart", you must be able to run the build AND it must be restartable). Make this more clear. Test Plan: {F6301739} Reviewers: amckinley Reviewed By: amckinley Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam Differential Revision: https://secure.phabricator.com/D20307 --- .../plan/HarbormasterBuildPlanBehavior.php | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/src/applications/harbormaster/plan/HarbormasterBuildPlanBehavior.php b/src/applications/harbormaster/plan/HarbormasterBuildPlanBehavior.php index d8e857e711..112926c47c 100644 --- a/src/applications/harbormaster/plan/HarbormasterBuildPlanBehavior.php +++ b/src/applications/harbormaster/plan/HarbormasterBuildPlanBehavior.php @@ -350,15 +350,19 @@ final class HarbormasterBuildPlanBehavior ->setKey(self::BEHAVIOR_RESTARTABLE) ->setEditInstructions( pht( - 'Usually, builds may be restarted. This may be useful if you '. - 'suspect a build has failed for environmental or circumstantial '. - 'reasons unrelated to the actual code, and want to give it '. - 'another chance at glory.'. + 'Usually, builds may be restarted by users who have permission '. + 'to edit the related build plan. (You can change who is allowed '. + 'to restart a build by adjusting the "Runnable" behavior.)'. + "\n\n". + 'Restarting a build may be useful if you suspect it has failed '. + 'for environmental or circumstantial reasons unrelated to the '. + 'actual code, and want to give it another chance at glory.'. "\n\n". 'If you want to prevent a build from being restarted, you can '. - 'change the behavior here. This may be useful to prevent '. - 'accidents where a build with a dangerous side effect (like '. - 'deployment) is restarted improperly.')) + 'change when it may be restarted by adjusting this behavior. '. + 'This may be useful to prevent accidents where a build with a '. + 'dangerous side effect (like deployment) is restarted '. + 'improperly.')) ->setName(pht('Restartable')) ->setOptions($restart_options), id(new self())