revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-19 20:10:55 +01:00
Code Issues Releases Wiki Activity

Pholio - upgrade herald effects to use transactions

Browse source 
Summary: Ref T4484

Test Plan: Made a mock. Made a herald rule to subscribe a user if mock had a string in title. Edited mock to have said string. Observed user subscribed correctly.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T4484

Differential Revision: https://secure.phabricator.com/D10725
This commit is contained in:
Bob Trahan 2014-10-17 13:55:39 -07:00
parent 9dd09f7171
commit 7a163ca654
1 changed files with 6 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
src/applications/pholio/editor/PholioMockEditor.php
View file

@ -462,18 +462,17 @@ final class PholioMockEditor extends PhabricatorApplicationTransactionEditor {
HeraldAdapter $adapter, HeraldAdapter $adapter,
HeraldTranscript $transcript) { HeraldTranscript $transcript) {
// TODO: Convert this to be transaction-based. $xactions = array();
$cc_phids = $adapter->getCcPHIDs(); $cc_phids = $adapter->getCcPHIDs();
if ($cc_phids) { if ($cc_phids) {
id(new PhabricatorSubscriptionsEditor()) $value = array_fuse($cc_phids);
->setObject($object) $xactions[] = id(new PholioTransaction())
->setActor($this->requireActor()) ->setTransactionType(PhabricatorTransactions::TYPE_SUBSCRIBERS)
->subscribeImplicit($cc_phids) ->setNewValue(array('+' => $value));
->save();
} }
return array(); return $xactions;
} }
protected function sortTransactions(array $xactions) { protected function sortTransactions(array $xactions) {