From 7a9c28d2d868cb89f843d394e7e37da60d1a93df Mon Sep 17 00:00:00 2001 From: epriestley Date: Sat, 19 Jan 2013 19:55:37 -0800 Subject: [PATCH] Delete the footer completely Summary: Fixes T2330. Deletes the last traces of the footer. Test Plan: Looked at several pages, saw no footer. Grepped for footer function and CSS class. Reviewers: DeedyDas, chad Reviewed By: chad CC: aran Maniphest Tasks: T2330 Differential Revision: https://secure.phabricator.com/D4554 --- src/__celerity_resource_map__.php | 82 +++++++++---------- src/view/page/PhabricatorStandardPageView.php | 22 +---- .../application/base/standard-page-view.css | 9 -- 3 files changed, 42 insertions(+), 71 deletions(-) diff --git a/src/__celerity_resource_map__.php b/src/__celerity_resource_map__.php index 84b3333a87..78e6ea2ac3 100644 --- a/src/__celerity_resource_map__.php +++ b/src/__celerity_resource_map__.php @@ -2829,7 +2829,7 @@ celerity_register_resource_map(array( ), 'phabricator-standard-page-view' => array( - 'uri' => '/res/6b3a7ce5/rsrc/css/application/base/standard-page-view.css', + 'uri' => '/res/5f013c46/rsrc/css/application/base/standard-page-view.css', 'type' => 'css', 'requires' => array( @@ -3229,7 +3229,7 @@ celerity_register_resource_map(array( ), array( 'packages' => array( - '6191f287' => + 'b4c8105f' => array( 'name' => 'core.pkg.css', 'symbols' => @@ -3273,7 +3273,7 @@ celerity_register_resource_map(array( 36 => 'phabricator-object-item-list-view-css', 37 => 'global-drag-and-drop-css', ), - 'uri' => '/res/pkg/6191f287/core.pkg.css', + 'uri' => '/res/pkg/b4c8105f/core.pkg.css', 'type' => 'css', ), 'c90b892e' => @@ -3463,19 +3463,19 @@ celerity_register_resource_map(array( 'reverse' => array( 'aphront-attached-file-view-css' => '2a1ed97f', - 'aphront-crumbs-view-css' => '6191f287', - 'aphront-dialog-view-css' => '6191f287', - 'aphront-error-view-css' => '6191f287', - 'aphront-form-view-css' => '6191f287', + 'aphront-crumbs-view-css' => 'b4c8105f', + 'aphront-dialog-view-css' => 'b4c8105f', + 'aphront-error-view-css' => 'b4c8105f', + 'aphront-form-view-css' => 'b4c8105f', 'aphront-headsup-action-list-view-css' => 'ec01d039', - 'aphront-headsup-view-css' => '6191f287', - 'aphront-list-filter-view-css' => '6191f287', - 'aphront-pager-view-css' => '6191f287', - 'aphront-panel-view-css' => '6191f287', - 'aphront-table-view-css' => '6191f287', - 'aphront-tokenizer-control-css' => '6191f287', - 'aphront-tooltip-css' => '6191f287', - 'aphront-typeahead-control-css' => '6191f287', + 'aphront-headsup-view-css' => 'b4c8105f', + 'aphront-list-filter-view-css' => 'b4c8105f', + 'aphront-pager-view-css' => 'b4c8105f', + 'aphront-panel-view-css' => 'b4c8105f', + 'aphront-table-view-css' => 'b4c8105f', + 'aphront-tokenizer-control-css' => 'b4c8105f', + 'aphront-tooltip-css' => 'b4c8105f', + 'aphront-typeahead-control-css' => 'b4c8105f', 'differential-changeset-view-css' => 'ec01d039', 'differential-core-view-css' => 'ec01d039', 'differential-inline-comment-editor' => 'ac53d36a', @@ -3489,7 +3489,7 @@ celerity_register_resource_map(array( 'differential-table-of-contents-css' => 'ec01d039', 'diffusion-commit-view-css' => 'c8ce2d88', 'diffusion-icons-css' => 'c8ce2d88', - 'global-drag-and-drop-css' => '6191f287', + 'global-drag-and-drop-css' => 'b4c8105f', 'inline-comment-summary-css' => 'ec01d039', 'javelin-aphlict' => 'c90b892e', 'javelin-behavior' => 'fbeded59', @@ -3559,48 +3559,48 @@ celerity_register_resource_map(array( 'javelin-util' => 'fbeded59', 'javelin-vector' => 'fbeded59', 'javelin-workflow' => 'fbeded59', - 'lightbox-attachment-css' => '6191f287', + 'lightbox-attachment-css' => 'b4c8105f', 'maniphest-task-summary-css' => '2a1ed97f', 'maniphest-transaction-detail-css' => '2a1ed97f', 'phabricator-busy' => 'c90b892e', 'phabricator-content-source-view-css' => 'ec01d039', - 'phabricator-core-buttons-css' => '6191f287', - 'phabricator-core-css' => '6191f287', - 'phabricator-crumbs-view-css' => '6191f287', - 'phabricator-directory-css' => '6191f287', + 'phabricator-core-buttons-css' => 'b4c8105f', + 'phabricator-core-css' => 'b4c8105f', + 'phabricator-crumbs-view-css' => 'b4c8105f', + 'phabricator-directory-css' => 'b4c8105f', 'phabricator-drag-and-drop-file-upload' => 'ac53d36a', 'phabricator-dropdown-menu' => 'c90b892e', 'phabricator-file-upload' => 'c90b892e', - 'phabricator-filetree-view-css' => '6191f287', - 'phabricator-flag-css' => '6191f287', - 'phabricator-form-view-css' => '6191f287', - 'phabricator-header-view-css' => '6191f287', - 'phabricator-jump-nav' => '6191f287', + 'phabricator-filetree-view-css' => 'b4c8105f', + 'phabricator-flag-css' => 'b4c8105f', + 'phabricator-form-view-css' => 'b4c8105f', + 'phabricator-header-view-css' => 'b4c8105f', + 'phabricator-jump-nav' => 'b4c8105f', 'phabricator-keyboard-shortcut' => 'c90b892e', 'phabricator-keyboard-shortcut-manager' => 'c90b892e', - 'phabricator-main-menu-view' => '6191f287', + 'phabricator-main-menu-view' => 'b4c8105f', 'phabricator-menu-item' => 'c90b892e', - 'phabricator-nav-view-css' => '6191f287', + 'phabricator-nav-view-css' => 'b4c8105f', 'phabricator-notification' => 'c90b892e', - 'phabricator-notification-css' => '6191f287', - 'phabricator-notification-menu-css' => '6191f287', - 'phabricator-object-item-list-view-css' => '6191f287', + 'phabricator-notification-css' => 'b4c8105f', + 'phabricator-notification-menu-css' => 'b4c8105f', + 'phabricator-object-item-list-view-css' => 'b4c8105f', 'phabricator-object-selector-css' => 'ec01d039', 'phabricator-paste-file-upload' => 'c90b892e', 'phabricator-prefab' => 'c90b892e', 'phabricator-project-tag-css' => '2a1ed97f', - 'phabricator-remarkup-css' => '6191f287', + 'phabricator-remarkup-css' => 'b4c8105f', 'phabricator-shaped-request' => 'ac53d36a', - 'phabricator-side-menu-view-css' => '6191f287', - 'phabricator-standard-page-view' => '6191f287', + 'phabricator-side-menu-view-css' => 'b4c8105f', + 'phabricator-standard-page-view' => 'b4c8105f', 'phabricator-textareautils' => 'c90b892e', 'phabricator-tooltip' => 'c90b892e', - 'phabricator-transaction-view-css' => '6191f287', - 'phabricator-zindex-css' => '6191f287', - 'sprite-apps-large-css' => '6191f287', - 'sprite-gradient-css' => '6191f287', - 'sprite-icon-css' => '6191f287', - 'sprite-menu-css' => '6191f287', - 'syntax-highlighting-css' => '6191f287', + 'phabricator-transaction-view-css' => 'b4c8105f', + 'phabricator-zindex-css' => 'b4c8105f', + 'sprite-apps-large-css' => 'b4c8105f', + 'sprite-gradient-css' => 'b4c8105f', + 'sprite-icon-css' => 'b4c8105f', + 'sprite-menu-css' => 'b4c8105f', + 'syntax-highlighting-css' => 'b4c8105f', ), )); diff --git a/src/view/page/PhabricatorStandardPageView.php b/src/view/page/PhabricatorStandardPageView.php index b28a2d1a42..f9735a79bc 100644 --- a/src/view/page/PhabricatorStandardPageView.php +++ b/src/view/page/PhabricatorStandardPageView.php @@ -229,13 +229,8 @@ final class PhabricatorStandardPageView extends PhabricatorBarePageView { } $header_chrome = null; - $footer_chrome = null; if ($this->getShowChrome()) { $header_chrome = $this->menuContent; - - if (!$this->getDeviceReady()) { - $footer_chrome = $this->renderFooter(); - } } $developer_warning = null; @@ -282,8 +277,7 @@ final class PhabricatorStandardPageView extends PhabricatorBarePageView { ($console ? '' : null). parent::getBody(). '
'. - ''). - $footer_chrome; + ''); } protected function getTail() { @@ -365,18 +359,4 @@ final class PhabricatorStandardPageView extends PhabricatorBarePageView { return $this->getRequest()->getApplicationConfiguration()->getConsole(); } - public function renderFooter() { - $console = $this->getConsole(); - - $foot_links = array(); - - - $foot_links = implode(' · ', $foot_links); - - return - '
'. - $foot_links. - '
'; - } - } diff --git a/webroot/rsrc/css/application/base/standard-page-view.css b/webroot/rsrc/css/application/base/standard-page-view.css index ac48717675..2bd948690b 100644 --- a/webroot/rsrc/css/application/base/standard-page-view.css +++ b/webroot/rsrc/css/application/base/standard-page-view.css @@ -17,15 +17,6 @@ border-width: 0px; } -.phabricator-page-foot { - text-align: right; - margin: 4em 2em; - border-top: 1px solid #dfdfdf; - padding: .5em 1em; - font-size: 11px; - color: #666666; -} - .keyboard-shortcut-help td, .keyboard-shortcut-help th { padding: 8px;