From 7acaeee8447ab33aab648773dde9b7bb942c82b6 Mon Sep 17 00:00:00 2001 From: Afaque Hussain Date: Tue, 5 Mar 2013 12:28:08 -0800 Subject: [PATCH] Augmented DifferentailDependsOnFieldSpecification to expose its data over conduit Summary: Implmented conduit methods from base class in DifferentialDependsOnFieldSpecification Test Plan: Created two test diffs, made one of them dependent on another. Then checked the dependency over conduit interface for differential.query. Dependency is shown but in terms of PHIDs Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5238 --- .../DifferentialDependsOnFieldSpecification.php | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/src/applications/differential/field/specification/DifferentialDependsOnFieldSpecification.php b/src/applications/differential/field/specification/DifferentialDependsOnFieldSpecification.php index b195641432..0c312854d4 100644 --- a/src/applications/differential/field/specification/DifferentialDependsOnFieldSpecification.php +++ b/src/applications/differential/field/specification/DifferentialDependsOnFieldSpecification.php @@ -35,4 +35,16 @@ final class DifferentialDependsOnFieldSpecification PhabricatorEdgeConfig::TYPE_DREV_DEPENDS_ON_DREV); } + public function shouldAppearOnConduitView() { + return true; + } + + public function getValueForConduit() { + return $this->getDependentRevisionPHIDs(); + } + + public function getKeyForConduit() { + return 'phabricator:depends-on'; + } + }