From 7b27653f5714fd58ad0b7997998a570a124f2106 Mon Sep 17 00:00:00 2001 From: lkassianik Date: Fri, 15 Apr 2016 10:52:01 -0700 Subject: [PATCH] Fixing UI Example that use badge qualities Summary: Fixes T10706 Test Plan: Open UI Example of badges. Shouldn't be broken Reviewers: epriestley, #blessed_reviewers, chad Reviewed By: #blessed_reviewers, chad Subscribers: Korvin Maniphest Tasks: T10706 Differential Revision: https://secure.phabricator.com/D15723 --- .../uiexample/examples/PHUIBadgeExample.php | 20 +++++++++---------- .../uiexample/examples/PHUIBoxExample.php | 2 +- .../examples/PHUITimelineExample.php | 5 ++--- 3 files changed, 13 insertions(+), 14 deletions(-) diff --git a/src/applications/uiexample/examples/PHUIBadgeExample.php b/src/applications/uiexample/examples/PHUIBadgeExample.php index 90c338f7e8..5207db753c 100644 --- a/src/applications/uiexample/examples/PHUIBadgeExample.php +++ b/src/applications/uiexample/examples/PHUIBadgeExample.php @@ -54,7 +54,7 @@ final class PHUIBadgeExample extends PhabricatorUIExample { ->setIcon('fa-user') ->setHeader(pht('Phabricator User')) ->setSubhead(pht('Confirmed your account.')) - ->setQuality(PHUIBadgeView::POOR) + ->setQuality(PhabricatorBadgesQuality::POOR) ->setSource(pht('People (automatic)')) ->addByline(pht('Dec 31, 1969')) ->addByline('212 Issued (100%)'); @@ -63,7 +63,7 @@ final class PHUIBadgeExample extends PhabricatorUIExample { ->setIcon('fa-code') ->setHeader(pht('Code Contributor')) ->setSubhead(pht('Wrote code that was acceptable')) - ->setQuality(PHUIBadgeView::COMMON) + ->setQuality(PhabricatorBadgesQuality::COMMON) ->setSource('Diffusion (automatic)') ->addByline(pht('Dec 31, 1969')) ->addByline('200 Awarded (98%)'); @@ -72,7 +72,7 @@ final class PHUIBadgeExample extends PhabricatorUIExample { ->setIcon('fa-bug') ->setHeader(pht('Task Master')) ->setSubhead(pht('Closed over 100 tasks')) - ->setQuality(PHUIBadgeView::UNCOMMON) + ->setQuality(PhabricatorBadgesQuality::UNCOMMON) ->setSource('Maniphest (automatic)') ->addByline(pht('Dec 31, 1969')) ->addByline('56 Awarded (43%)'); @@ -81,7 +81,7 @@ final class PHUIBadgeExample extends PhabricatorUIExample { ->setIcon('fa-star') ->setHeader(pht('Code Weaver')) ->setSubhead(pht('Landed 1,000 Commits')) - ->setQuality(PHUIBadgeView::RARE) + ->setQuality(PhabricatorBadgesQuality::RARE) ->setSource('Diffusion (automatic)') ->addByline(pht('Dec 31, 1969')) ->addByline('42 Awarded (20%)'); @@ -90,7 +90,7 @@ final class PHUIBadgeExample extends PhabricatorUIExample { ->setIcon('fa-users') ->setHeader(pht('Security Team')) ->setSubhead(pht('')) - ->setQuality(PHUIBadgeView::EPIC) + ->setQuality(PhabricatorBadgesQuality::EPIC) ->setSource('Projects (automatic)') ->addByline(pht('Dec 31, 1969')) ->addByline('21 Awarded (10%)'); @@ -99,7 +99,7 @@ final class PHUIBadgeExample extends PhabricatorUIExample { ->setIcon('fa-user') ->setHeader(pht('Adminstrator')) ->setSubhead(pht('Drew the short stick')) - ->setQuality(PHUIBadgeView::LEGENDARY) + ->setQuality(PhabricatorBadgesQuality::LEGENDARY) ->setSource(pht('People (automatic)')) ->addByline(pht('Dec 31, 1969')) ->addByline('3 Awarded (1.4%)'); @@ -108,7 +108,7 @@ final class PHUIBadgeExample extends PhabricatorUIExample { ->setIcon('fa-compass') ->setHeader(pht('Lead Developer')) ->setSubhead(pht('Lead Developer of Phabricator')) - ->setQuality(PHUIBadgeView::HEIRLOOM) + ->setQuality(PhabricatorBadgesQuality::HEIRLOOM) ->setSource(pht('Direct Award (epriestley)')) ->addByline(pht('Dec 31, 1969')) ->addByline('1 Awarded (0.4%)'); @@ -129,17 +129,17 @@ final class PHUIBadgeExample extends PhabricatorUIExample { $badges3[] = id(new PHUIBadgeMiniView()) ->setIcon('fa-heart') ->setHeader(pht('Funder')) - ->setQuality(PHUIBadgeView::UNCOMMON); + ->setQuality(PhabricatorBadgesQuality::UNCOMMON); $badges3[] = id(new PHUIBadgeMiniView()) ->setIcon('fa-user') ->setHeader(pht('Administrator')) - ->setQuality(PHUIBadgeView::RARE); + ->setQuality(PhabricatorBadgesQuality::RARE); $badges3[] = id(new PHUIBadgeMiniView()) ->setIcon('fa-camera-retro') ->setHeader(pht('Designer')) - ->setQuality(PHUIBadgeView::EPIC); + ->setQuality(PhabricatorBadgesQuality::EPIC); $flex1 = new PHUIBadgeBoxView(); $flex1->addItems($badges1); diff --git a/src/applications/uiexample/examples/PHUIBoxExample.php b/src/applications/uiexample/examples/PHUIBoxExample.php index 9634520e89..7a2674da94 100644 --- a/src/applications/uiexample/examples/PHUIBoxExample.php +++ b/src/applications/uiexample/examples/PHUIBoxExample.php @@ -75,7 +75,7 @@ final class PHUIBoxExample extends PhabricatorUIExample { $badge2 = id(new PHUIBadgeMiniView()) ->setIcon('fa-heart') ->setHeader(pht('Funder')) - ->setQuality(PHUIBadgeView::UNCOMMON); + ->setQuality(PhabricatorBadgesQuality::UNCOMMON); $header = id(new PHUIHeaderView()) ->setHeader(pht('Fancy Box')) diff --git a/src/applications/uiexample/examples/PHUITimelineExample.php b/src/applications/uiexample/examples/PHUITimelineExample.php index 661d2e6899..9bedffd9eb 100644 --- a/src/applications/uiexample/examples/PHUITimelineExample.php +++ b/src/applications/uiexample/examples/PHUITimelineExample.php @@ -1,5 +1,4 @@ setIcon('fa-camera-retro') ->setHeader(pht('Designer')) - ->setQuality(PHUIBadgeView::EPIC); + ->setQuality(PhabricatorBadgesQuality::EPIC); $admin = id(new PHUIBadgeMiniView()) ->setIcon('fa-user') ->setHeader(pht('Administrator')) - ->setQuality(PHUIBadgeView::RARE); + ->setQuality(PhabricatorBadgesQuality::RARE); $events = array();