revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-10 08:52:39 +01:00
Code Issues Releases Wiki Activity

Change "Revision Close" story to use commit identities only with no fallback to commit data

Browse source 
Summary:
See PHI1213. If we don't have identities for "revision X closed by commit Y" stories, just do the plain non-attribution rendering rather than trying to fall back. Falling back won't work since we don't load the data, which should be OK now since identities seem like they're in generally good shape.

(We could probably just throw out the fallback behavior instead, but we can always clean things up later.)

Test Plan: Forced no commit identity on a revision, loaded it, saw reasonable story rendering.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D20460
This commit is contained in:
epriestley 2019-04-22 12:42:39 -07:00
parent b0b8926c75
commit 7b8ac020b5
1 changed files with 11 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
src/applications/differential/xaction/DifferentialRevisionCloseTransaction.php
View file

@ -100,8 +100,17 @@ final class DifferentialRevisionCloseTransaction
$this->renderAuthor());
}
$author_phid = $commit->getAuthorDisplayPHID();
$committer_phid = $commit->getCommitterDisplayPHID();
$author_phid = null;
if ($commit->hasAuthorIdentity()) {
$identity = $commit->getAuthorIdentity();
$author_phid = $identity->getIdentityDisplayPHID();
}
$committer_phid = null;
if ($commit->hasCommitterIdentity()) {
$identity = $commit->getCommitterIdentity();
$committer_phid = $identity->getIdentityDisplayPHID();
}
if (!$author_phid) {
return pht(