revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-19 03:50:54 +01:00
Code Issues Releases Wiki Activity

Move DifferentialRevisionViewController to newPage()

Browse source 
Summary: I think this works?

Test Plan:
i am wizard

{F1168808}

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D15457
This commit is contained in:
epriestley 2016-03-10 13:18:58 -08:00
parent 31984a78ee
commit 7b8da99914
1 changed files with 12 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
src/applications/differential/controller/DifferentialRevisionViewController.php
View file

@ -481,19 +481,21 @@ final class DifferentialRevisionViewController extends DifferentialController {
->setBaseURI(new PhutilURI('/D'.$revision->getID())) ->setBaseURI(new PhutilURI('/D'.$revision->getID()))
->setCollapsed((bool)$collapsed) ->setCollapsed((bool)$collapsed)
->build($changesets); ->build($changesets);
$nav->appendChild($content);
$nav->setCrumbs($crumbs);
$content = $nav;
} else { } else {
array_unshift($content, $crumbs); $nav = null;
} }
return $this->buildApplicationPage( $page = $this->newPage()
$content, ->setTitle($object_id.' '.$revision->getTitle())
array( ->setCrumbs($crumbs)
'title' => $object_id.' '.$revision->getTitle(), ->setPageObjectPHIDs(array($revision->getPHID()))
'pageObjects' => array($revision->getPHID()), ->appendChild($content);
));
if ($nav) {
$page->setNavigation($nav);
}
return $page;
} }
private function getRevisionActions(DifferentialRevision $revision) { private function getRevisionActions(DifferentialRevision $revision) {