mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-20 20:40:56 +01:00
Move DifferentialRevisionViewController to newPage()
Summary: I think this works? Test Plan: i am wizard {F1168808} Reviewers: chad Reviewed By: chad Differential Revision: https://secure.phabricator.com/D15457
This commit is contained in:
parent
31984a78ee
commit
7b8da99914
1 changed files with 12 additions and 10 deletions
|
@ -481,19 +481,21 @@ final class DifferentialRevisionViewController extends DifferentialController {
|
|||
->setBaseURI(new PhutilURI('/D'.$revision->getID()))
|
||||
->setCollapsed((bool)$collapsed)
|
||||
->build($changesets);
|
||||
$nav->appendChild($content);
|
||||
$nav->setCrumbs($crumbs);
|
||||
$content = $nav;
|
||||
} else {
|
||||
array_unshift($content, $crumbs);
|
||||
$nav = null;
|
||||
}
|
||||
|
||||
return $this->buildApplicationPage(
|
||||
$content,
|
||||
array(
|
||||
'title' => $object_id.' '.$revision->getTitle(),
|
||||
'pageObjects' => array($revision->getPHID()),
|
||||
));
|
||||
$page = $this->newPage()
|
||||
->setTitle($object_id.' '.$revision->getTitle())
|
||||
->setCrumbs($crumbs)
|
||||
->setPageObjectPHIDs(array($revision->getPHID()))
|
||||
->appendChild($content);
|
||||
|
||||
if ($nav) {
|
||||
$page->setNavigation($nav);
|
||||
}
|
||||
|
||||
return $page;
|
||||
}
|
||||
|
||||
private function getRevisionActions(DifferentialRevision $revision) {
|
||||
|
|
Loading…
Reference in a new issue