revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-22 06:42:42 +01:00
Code Issues Releases Wiki Activity

Drag & Drop: fix JavaScript error related to JX.$(undefined)

Browse source 
Summary:
This change fixes the following recent JavaScript error:

    Error: Empty ID passed to JX.$()!

The regression was introduced here:

90f9da643d

Closes T15272

Test Plan: - with this change I was able to open Conpherence Persistent Chat and Drop a file

Reviewers: O1 Blessed Committers, Dylsss, avivey

Reviewed By: O1 Blessed Committers, avivey

Subscribers: Dylsss, speck, tobiaswiese, Matthew, Cigaryno

Maniphest Tasks: T15272

Differential Revision: https://we.phorge.it/D25134
This commit is contained in:
Valerio Bozzolan 2023-04-26 09:49:35 +02:00
parent a89b4ff5b8
commit 7bd4089a26
1 changed files with 9 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
webroot/rsrc/js/core/behavior-drag-and-drop-textarea.js
View file

@ -27,11 +27,15 @@ JX.behavior('aphront-drag-and-drop-textarea', function(config) {
drop.listen('didUpload', function(file) {
JX.TextAreaUtils.insertFileReference(target, file);
var metadata = new JX.RemarkupMetadata(config.remarkupMetadataValue,
config.remarkupMetadataID);
var phids = metadata.getMetadata('attachedFilePHIDs', []);
phids.push(file.getPHID());
metadata.setMetadata('attachedFilePHIDs', phids);
if(config.remarkupMetadataID) {
// Try to auto-attach files by default
// https://we.phorge.it/T15106
var metadata = new JX.RemarkupMetadata(config.remarkupMetadataValue,
config.remarkupMetadataID);
var phids = metadata.getMetadata('attachedFilePHIDs', []);
phids.push(file.getPHID());
metadata.setMetadata('attachedFilePHIDs', phids);
}
});
drop.start();