revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-18 04:42:40 +01:00
Code Issues Releases Wiki Activity

Change migrations to not rely on "arcanist project" classes

Browse source 
Summary: Ref T7604. Change two migrations to query arcanist project information using `queryfx` directly to avoid the need for the `LiskDAO` fields to exist.

Test Plan:
Ran the following commands to verify that things weren't majorly broken:

  - `./bin/storage upgrade --apply phabricator:20150503.repositorysymbols.2.php`
  - `./bin/storage upgrade --no-quickstart --namespace test`

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T7604

Differential Revision: https://secure.phabricator.com/D13011
This commit is contained in:
Joshua Spence 2015-06-01 15:35:13 +10:00
parent bb92819c09
commit 7bea116b00
2 changed files with 12 additions and 41 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
resources/sql/autopatches/20150503.repositorysymbols.2.php
View file

@ -1,26 +1,29 @@
<?php <?php
$projects = id(new PhabricatorRepositoryArcanistProjectQuery())
->setViewer(PhabricatorUser::getOmnipotentUser())
->needRepositories(true)
->execute();
$table = new PhabricatorRepositorySymbol(); $table = new PhabricatorRepositorySymbol();
$conn_w = $table->establishConnection('w'); $conn_w = $table->establishConnection('w');
$projects = queryfx_all(
$conn_w,
'SELECT * FROM %T',
'repository_arcanistproject');
foreach ($projects as $project) { foreach ($projects as $project) {
$repo = $project->getRepository(); $repo = id(new PhabricatorRepositoryQuery())
->setViewer(PhabricatorUser::getOmnipotentUser())
->withIDs(array($project['repository']))
->executeOne();
if (!$repo) { if (!$repo) {
continue; continue;
} }
echo pht("Migrating symbols for '%s' project...\n", $project->getName()); echo pht("Migrating symbols for '%s' project...\n", $project['name']);
queryfx( queryfx(
$conn_w, $conn_w,
'UPDATE %T SET repositoryPHID = %s WHERE arcanistProjectID = %d', 'UPDATE %T SET repositoryPHID = %s WHERE arcanistProjectID = %d',
$table->getTableName(), $table->getTableName(),
$repo->getPHID(), $repo->getPHID(),
$project->getID()); $project['id']);
} }

34
resources/sql/patches/131.migraterevisionquery.php
View file

@ -1,35 +1,3 @@
<?php <?php
$table = new DifferentialRevision(); // This migration has been dropped, see T7604 for details.
$table->openTransaction();
$table->beginReadLocking();
$conn_w = $table->establishConnection('w');
echo pht('Migrating revisions')."\n";
do {
$revisions = $table->loadAllWhere('branchName IS NULL LIMIT 1000');
foreach ($revisions as $revision) {
echo '.';
$diff = $revision->loadActiveDiff();
if (!$diff) {
continue;
}
$branch_name = $diff->getBranch();
$arc_project_phid = $diff->getArcanistProjectPHID();
queryfx(
$conn_w,
'UPDATE %T SET branchName = %s, arcanistProjectPHID = %s WHERE id = %d',
$table->getTableName(),
$branch_name,
$arc_project_phid,
$revision->getID());
}
} while (count($revisions) == 1000);
$table->endReadLocking();
$table->saveTransaction();
echo "\n".pht('Done.')."\n";