revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-10 00:42:41 +01:00
Code Issues Releases Wiki Activity

Add more useful PHIDs to Harbormaster build variables

Browse source 
Summary: Ref T13609. Add the Object PHID (object being built), Container PHID (container of the object being built), Build PHID, and Buildable PHID to Harbormaster build variables.

Test Plan:
{F8448191}

{F8448192}

Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam

Maniphest Tasks: T13609

Differential Revision: https://secure.phabricator.com/D21569
This commit is contained in:
epriestley 2021-02-18 13:34:07 -08:00
parent 8cfd22c5fe
commit 7c44657ca5
1 changed files with 20 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
src/applications/harbormaster/storage/build/HarbormasterBuild.php
View file

@ -128,6 +128,11 @@ final class HarbormasterBuild extends HarbormasterDAO
'step.timestamp' => null, 'step.timestamp' => null,
'build.id' => null, 'build.id' => null,
'initiator.phid' => null, 'initiator.phid' => null,
'buildable.phid' => null,
'buildable.object.phid' => null,
'buildable.container.phid' => null,
'build.phid' => null,
); );
foreach ($this->getBuildParameters() as $key => $value) { foreach ($this->getBuildParameters() as $key => $value) {
@ -145,6 +150,11 @@ final class HarbormasterBuild extends HarbormasterDAO
$results['build.id'] = $this->getID(); $results['build.id'] = $this->getID();
$results['initiator.phid'] = $this->getInitiatorPHID(); $results['initiator.phid'] = $this->getInitiatorPHID();
$results['buildable.phid'] = $buildable->getPHID();
$results['buildable.object.phid'] = $object->getPHID();
$results['buildable.container.phid'] = $buildable->getContainerPHID();
$results['build.phid'] = $this->getPHID();
return $results; return $results;
} }
@ -161,6 +171,16 @@ final class HarbormasterBuild extends HarbormasterDAO
'initiator.phid' => pht( 'initiator.phid' => pht(
'The PHID of the user or Object that initiated the build, '. 'The PHID of the user or Object that initiated the build, '.
'if applicable.'), 'if applicable.'),
'buildable.phid' => pht(
'The object PHID of the Harbormaster Buildable being built.'),
'buildable.object.phid' => pht(
'The object PHID of the object (usually a diff or commit) '.
'being built.'),
'buildable.container.phid' => pht(
'The object PHID of the container (usually a revision or repository) '.
'for the object being built.'),
'build.phid' => pht(
'The object PHID of the Harbormaster Build being built.'),
); );
foreach ($objects as $object) { foreach ($objects as $object) {