revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-10 00:42:41 +01:00
Code Issues Releases Wiki Activity

Let omnipotent actors skip MFA transactions

Browse source 
Summary: This seems generally reasonable, but is also a narrow fix to "Phacility scripts try to move instances into 'up', but the daemons can't MFA".

Test Plan: Launched a new instance locally, no more "daemons can't MFA" error.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D20081
This commit is contained in:
epriestley 2019-01-31 17:14:18 -08:00
parent 942d6d60d5
commit 7c795ab757
1 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
View file

@ -4856,6 +4856,13 @@ abstract class PhabricatorApplicationTransactionEditor
}
private function requireMFA(PhabricatorLiskDAO $object, array $xactions) {
$actor = $this->getActor();
// Let omnipotent editors skip MFA. This is mostly aimed at scripts.
if ($actor->isOmnipotent()) {
return;
}
$editor_class = get_class($this);
$object_phid = $object->getPHID();
@ -4870,8 +4877,6 @@ abstract class PhabricatorApplicationTransactionEditor
$editor_class);
}
$actor = $this->getActor();
$request = $this->getRequest();
if ($request === null) {
$source_type = $this->getContentSource()->getSourceTypeConstant();