From 7c9e73b31d4a97851232616e17a7c0aff22ce1c0 Mon Sep 17 00:00:00 2001
From: Chad Little <chad@chadsdomain.com>
Date: Fri, 20 Feb 2015 16:00:39 -0800
Subject: [PATCH] Remove AphrontMiniPanelView

Summary: Swaps out AphrontMiniPanelView usage with PHUIErrorView. Only used on homepage.

Test Plan:
Grepped for usage, only home. Revisit a new home, see modern componant.

{F310934}

Reviewers: btrahan, epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D11842
---
 resources/celerity/map.php                          |  6 +++---
 src/__phutil_library_map__.php                      |  2 --
 .../controller/PhabricatorHomeMainController.php    |  3 ++-
 src/view/layout/AphrontMiniPanelView.php            | 12 ------------
 webroot/rsrc/css/aphront/panel-view.css             | 13 -------------
 5 files changed, 5 insertions(+), 31 deletions(-)
 delete mode 100644 src/view/layout/AphrontMiniPanelView.php

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
index ff5ef4c40d..b64289e8a4 100644
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -7,7 +7,7 @@
  */
 return array(
   'names' => array(
-    'core.pkg.css' => '26a65a65',
+    'core.pkg.css' => 'd31eec13',
     'core.pkg.js' => '23d653bb',
     'darkconsole.pkg.js' => '8ab24e01',
     'differential.pkg.css' => '380f07e5',
@@ -25,7 +25,7 @@ return array(
     'rsrc/css/aphront/multi-column.css' => '41a848c0',
     'rsrc/css/aphront/notification.css' => '9c279160',
     'rsrc/css/aphront/pager-view.css' => '2e3539af',
-    'rsrc/css/aphront/panel-view.css' => 'a5fee23a',
+    'rsrc/css/aphront/panel-view.css' => '7e0c3a56',
     'rsrc/css/aphront/phabricator-nav-view.css' => '7aeaf435',
     'rsrc/css/aphront/table-view.css' => 'b22b7216',
     'rsrc/css/aphront/tokenizer.css' => '82ce2142',
@@ -505,7 +505,7 @@ return array(
     'aphront-list-filter-view-css' => '2ae43867',
     'aphront-multi-column-view-css' => '41a848c0',
     'aphront-pager-view-css' => '2e3539af',
-    'aphront-panel-view-css' => 'a5fee23a',
+    'aphront-panel-view-css' => '7e0c3a56',
     'aphront-table-view-css' => 'b22b7216',
     'aphront-tokenizer-control-css' => '82ce2142',
     'aphront-tooltip-css' => '4099b97e',
diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php
index 231f6fcfd4..f698d3f6d1 100644
--- a/src/__phutil_library_map__.php
+++ b/src/__phutil_library_map__.php
@@ -144,7 +144,6 @@ phutil_register_library_map(array(
     'AphrontJavelinView' => 'view/AphrontJavelinView.php',
     'AphrontKeyboardShortcutsAvailableView' => 'view/widget/AphrontKeyboardShortcutsAvailableView.php',
     'AphrontListFilterView' => 'view/layout/AphrontListFilterView.php',
-    'AphrontMiniPanelView' => 'view/layout/AphrontMiniPanelView.php',
     'AphrontMoreView' => 'view/layout/AphrontMoreView.php',
     'AphrontMultiColumnView' => 'view/layout/AphrontMultiColumnView.php',
     'AphrontMySQLDatabaseConnectionTestCase' => 'infrastructure/storage/__tests__/AphrontMySQLDatabaseConnectionTestCase.php',
@@ -3293,7 +3292,6 @@ phutil_register_library_map(array(
     'AphrontJavelinView' => 'AphrontView',
     'AphrontKeyboardShortcutsAvailableView' => 'AphrontView',
     'AphrontListFilterView' => 'AphrontView',
-    'AphrontMiniPanelView' => 'AphrontView',
     'AphrontMoreView' => 'AphrontView',
     'AphrontMultiColumnView' => 'AphrontView',
     'AphrontMySQLDatabaseConnectionTestCase' => 'PhabricatorTestCase',
diff --git a/src/applications/home/controller/PhabricatorHomeMainController.php b/src/applications/home/controller/PhabricatorHomeMainController.php
index 44c2ea8447..cb323afc44 100644
--- a/src/applications/home/controller/PhabricatorHomeMainController.php
+++ b/src/applications/home/controller/PhabricatorHomeMainController.php
@@ -327,7 +327,8 @@ final class PhabricatorHomeMainController extends PhabricatorHomeController {
   }
 
   private function renderMiniPanel($title, $body) {
-    $panel = new AphrontMiniPanelView();
+    $panel = new PHUIErrorView();
+    $panel->setSeverity(PHUIErrorView::SEVERITY_NODATA);
     $panel->appendChild(
       phutil_tag(
         'p',
diff --git a/src/view/layout/AphrontMiniPanelView.php b/src/view/layout/AphrontMiniPanelView.php
deleted file mode 100644
index 474eff4686..0000000000
--- a/src/view/layout/AphrontMiniPanelView.php
+++ /dev/null
@@ -1,12 +0,0 @@
-<?php
-
-final class AphrontMiniPanelView extends AphrontView {
-
-  public function render() {
-    return phutil_tag(
-      'div',
-      array('class' => 'aphront-mini-panel-view'),
-      $this->renderChildren());
-  }
-
-}
diff --git a/webroot/rsrc/css/aphront/panel-view.css b/webroot/rsrc/css/aphront/panel-view.css
index 6c3a50d32e..9335c4855c 100644
--- a/webroot/rsrc/css/aphront/panel-view.css
+++ b/webroot/rsrc/css/aphront/panel-view.css
@@ -118,16 +118,3 @@
   background: #ccffcc;
   border-color: #669966;
 }
-
-.aphront-mini-panel-view {
-  background: #fff;
-  padding: 10px;
-  margin: 16px 16px 0 16px;
-  border: 1px solid {$lightgreyborder};
-  border-bottom: 1px solid {$greyborder};
-}
-
-.aphront-mini-panel-view p {
-  font-size: 12px;
-  color: {$greytext};
-}