From 7cdee1884ec8136c6a6a3187f63957c9804ad2ad Mon Sep 17 00:00:00 2001 From: Bob Trahan Date: Tue, 26 Aug 2014 15:05:54 -0700 Subject: [PATCH] Feed - permenantly fail publish workers if the uri they are posting to is not in configu Summary: Fixes T5958 Test Plan: i just used the ole logic noodle on this one Reviewers: epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T5958 Differential Revision: https://secure.phabricator.com/D10359 --- src/applications/feed/worker/FeedPublisherHTTPWorker.php | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/applications/feed/worker/FeedPublisherHTTPWorker.php b/src/applications/feed/worker/FeedPublisherHTTPWorker.php index e949359f18..e4e0600cb1 100644 --- a/src/applications/feed/worker/FeedPublisherHTTPWorker.php +++ b/src/applications/feed/worker/FeedPublisherHTTPWorker.php @@ -7,6 +7,10 @@ final class FeedPublisherHTTPWorker extends FeedPushWorker { $data = $story->getStoryData(); $uri = idx($this->getTaskData(), 'uri'); + $valid_uris = PhabricatorEnv::getEnvConfig('feed.http-hooks'); + if (!in_array($uri, $valid_uris)) { + throw new PhabricatorWorkerPermanentFailureException(); + } $post_data = array( 'storyID' => $data->getID(),