From 7d1809f9352f3b8446e2179a084cc928ba5e6157 Mon Sep 17 00:00:00 2001 From: epriestley Date: Thu, 21 Jan 2016 10:05:48 -0800 Subject: [PATCH] Remove unused `appIcon` from PHUIListItemView Summary: This is unused and there's no way to even set it. Pretty sure it died a while ago when we switched app icons to FontAwesome. Test Plan: Grepped for `appIcon`, found no related hits. Browsed some pages. Reviewers: chad Reviewed By: chad Differential Revision: https://secure.phabricator.com/D15074 --- src/view/phui/PHUIListItemView.php | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/src/view/phui/PHUIListItemView.php b/src/view/phui/PHUIListItemView.php index 1173319f4e..abe1c11409 100644 --- a/src/view/phui/PHUIListItemView.php +++ b/src/view/phui/PHUIListItemView.php @@ -19,7 +19,6 @@ final class PHUIListItemView extends AphrontTagView { private $isExternal; private $key; private $icon; - private $appIcon; private $selected; private $disabled; private $renderNameAsTooltip; @@ -179,7 +178,7 @@ final class PHUIListItemView extends AphrontTagView { $classes[] = 'phui-list-item-view'; $classes[] = 'phui-list-item-'.$this->type; - if ($this->icon || $this->appIcon) { + if ($this->icon) { $classes[] = 'phui-list-item-has-icon'; } @@ -279,12 +278,6 @@ final class PHUIListItemView extends AphrontTagView { ->setImage($this->profileImage); } - if ($this->appIcon) { - $icon = id(new PHUIIconView()) - ->addClass('phui-list-item-icon') - ->setIconFont($this->appIcon); - } - $classes = array(); if ($this->href) { $classes[] = 'phui-list-item-href';