From 7d6133929a6650bc910761e7360f07a69880a0e5 Mon Sep 17 00:00:00 2001 From: epriestley Date: Tue, 16 May 2017 06:50:47 -0700 Subject: [PATCH] Resize the Differential keyboard focus reticle when the window is resized Summary: Fixes T12632. Ref T12634. Currently, the keyboard focus reticle does not redraw properly after a window resize. Test Plan: - Used "n" to select a block. - Resized the window. - Saw the reticle also resize properly. Reviewers: chad Reviewed By: chad Maniphest Tasks: T12634, T12632 Differential Revision: https://secure.phabricator.com/D17901 --- resources/celerity/map.php | 12 ++++++------ .../rsrc/js/application/diff/DiffChangesetList.js | 7 +++++++ 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/resources/celerity/map.php b/resources/celerity/map.php index 0a321e9a59..ab3628f264 100644 --- a/resources/celerity/map.php +++ b/resources/celerity/map.php @@ -13,7 +13,7 @@ return array( 'core.pkg.js' => '115cb4da', 'darkconsole.pkg.js' => '1f9a31bc', 'differential.pkg.css' => '58712637', - 'differential.pkg.js' => 'd831041b', + 'differential.pkg.js' => '14ef6888', 'diffusion.pkg.css' => 'b93d9b8c', 'diffusion.pkg.js' => '84c8f8fd', 'favicon.ico' => '30672e08', @@ -391,7 +391,7 @@ return array( 'rsrc/js/application/dashboard/behavior-dashboard-query-panel-select.js' => '453c5375', 'rsrc/js/application/dashboard/behavior-dashboard-tab-panel.js' => 'd4eecc63', 'rsrc/js/application/diff/DiffChangeset.js' => 'f7100923', - 'rsrc/js/application/diff/DiffChangesetList.js' => 'c457058f', + 'rsrc/js/application/diff/DiffChangesetList.js' => 'e5c5e171', 'rsrc/js/application/diff/DiffInline.js' => '00db3c3a', 'rsrc/js/application/diff/behavior-preview-link.js' => '051c7832', 'rsrc/js/application/differential/behavior-comment-jump.js' => '4fdb476d', @@ -782,7 +782,7 @@ return array( 'phabricator-darkmessage' => 'c48cccdd', 'phabricator-dashboard-css' => 'fe5b1869', 'phabricator-diff-changeset' => 'f7100923', - 'phabricator-diff-changeset-list' => 'c457058f', + 'phabricator-diff-changeset-list' => 'e5c5e171', 'phabricator-diff-inline' => '00db3c3a', 'phabricator-drag-and-drop-file-upload' => '58dea2fa', 'phabricator-draggable-list' => 'bea6e7f4', @@ -1922,9 +1922,6 @@ return array( 'javelin-stratcom', 'phabricator-tooltip', ), - 'c457058f' => array( - 'javelin-install', - ), 'c587b80f' => array( 'javelin-install', ), @@ -2140,6 +2137,9 @@ return array( 'javelin-workflow', 'javelin-magical-init', ), + 'e5c5e171' => array( + 'javelin-install', + ), 'e9581f08' => array( 'javelin-behavior', 'javelin-stratcom', diff --git a/webroot/rsrc/js/application/diff/DiffChangesetList.js b/webroot/rsrc/js/application/diff/DiffChangesetList.js index f9a3c5d5d9..cdb61c0a15 100644 --- a/webroot/rsrc/js/application/diff/DiffChangesetList.js +++ b/webroot/rsrc/js/application/diff/DiffChangesetList.js @@ -47,6 +47,9 @@ JX.install('DiffChangesetList', { 'click', ['differential-inline-comment', 'differential-inline-reply'], onreply); + + var onresize = JX.bind(this, this._ifawake, this._onresize); + JX.Stratcom.listen('resize', null, onresize); }, properties: { @@ -584,6 +587,10 @@ JX.install('DiffChangesetList', { inline.setHidden(is_hide); }, + _onresize: function() { + this._redrawFocus(); + }, + _onaction: function(action, e) { e.kill();