From 7d9eb8baaf86994fdafa3f08b1cbd7e15c96d403 Mon Sep 17 00:00:00 2001 From: Bob Trahan Date: Mon, 13 Oct 2014 16:45:58 -0700 Subject: [PATCH] Transactions - fix doorkeeper feed story error Summary: missing a setHandles on this codepath I think...? Fixes T6300. Test Plan: not actually tested - I just think this is the fix since the other renderX methods all do this setHandles thing and I can't figure out how handles get set otherwise... Reviewers: epriestley, avivey Reviewed By: epriestley, avivey Subscribers: avivey, Korvin, epriestley Maniphest Tasks: T6300 Differential Revision: https://secure.phabricator.com/D10699 --- .../feed/PhabricatorApplicationTransactionFeedStory.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/applications/transactions/feed/PhabricatorApplicationTransactionFeedStory.php b/src/applications/transactions/feed/PhabricatorApplicationTransactionFeedStory.php index 923ac77e24..57e65f8bbc 100644 --- a/src/applications/transactions/feed/PhabricatorApplicationTransactionFeedStory.php +++ b/src/applications/transactions/feed/PhabricatorApplicationTransactionFeedStory.php @@ -110,7 +110,9 @@ class PhabricatorApplicationTransactionFeedStory $xactions = array(); $xaction_phids = $this->getValue('transactionPHIDs'); foreach ($xaction_phids as $xaction_phid) { - $xactions[] = $this->getObject($xaction_phid); + $xaction = $this->getObject($xaction_phid); + $xaction->setHandles($this->getHandles()); + $xactions[] = $xaction; } $primary = $this->getPrimaryTransaction();