From 7dd31a16d973bf1c7a62b59e5bef6a0f5f1525d8 Mon Sep 17 00:00:00 2001 From: epriestley Date: Tue, 22 Oct 2013 13:47:47 -0700 Subject: [PATCH] Fix chatlog application query integration Summary: `class_exists()` is case-insensitive, but `PhabricatorApplication::getByClass()` is not. Test Plan: Fixed unit test to fail, then fixed code to pass unit test. Reviewers: btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D7379 --- src/applications/chatlog/PhabricatorChatLogChannelQuery.php | 2 +- src/applications/chatlog/PhabricatorChatLogQuery.php | 2 +- src/applications/policy/__tests__/PhabricatorPolicyTestCase.php | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/applications/chatlog/PhabricatorChatLogChannelQuery.php b/src/applications/chatlog/PhabricatorChatLogChannelQuery.php index cba9976c79..093bb0283d 100644 --- a/src/applications/chatlog/PhabricatorChatLogChannelQuery.php +++ b/src/applications/chatlog/PhabricatorChatLogChannelQuery.php @@ -57,7 +57,7 @@ final class PhabricatorChatLogChannelQuery } public function getQueryApplicationClass() { - return 'PhabricatorApplicationChatlog'; + return 'PhabricatorApplicationChatLog'; } } diff --git a/src/applications/chatlog/PhabricatorChatLogQuery.php b/src/applications/chatlog/PhabricatorChatLogQuery.php index 599a1d5c6d..c5b1f8ac66 100644 --- a/src/applications/chatlog/PhabricatorChatLogQuery.php +++ b/src/applications/chatlog/PhabricatorChatLogQuery.php @@ -56,7 +56,7 @@ final class PhabricatorChatLogQuery } public function getQueryApplicationClass() { - return 'PhabricatorApplicationChatlog'; + return 'PhabricatorApplicationChatLog'; } } diff --git a/src/applications/policy/__tests__/PhabricatorPolicyTestCase.php b/src/applications/policy/__tests__/PhabricatorPolicyTestCase.php index 6dcbc6a78d..edd41d9c6b 100644 --- a/src/applications/policy/__tests__/PhabricatorPolicyTestCase.php +++ b/src/applications/policy/__tests__/PhabricatorPolicyTestCase.php @@ -222,7 +222,7 @@ final class PhabricatorPolicyTestCase extends PhabricatorTestCase { } $this->assertEqual( true, - class_exists($class), + (bool)PhabricatorApplication::getByClass($class), "Application class '{$class}' for query '{$qclass}'"); } }