revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-02-25 13:09:08 +01:00
Code Issues Releases Wiki Activity

(stable) Fix an EditEngine issue with unlocking fields which can't be locked

Browse source 
Summary: This code should go inside the field-locking loop. Otherwise, it only applies to the last field, and fatals if there are no fields.

Test Plan: Carefuller inspection.

Reviewers: chad

Reviewed By: chad

Subscribers: 20after4

Differential Revision: https://secure.phabricator.com/D16889
This commit is contained in:
epriestley 2016-11-17 10:23:39 -08:00
parent e053534c7e
commit 7ebc47d906
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/transactions/storage/PhabricatorEditEngineConfiguration.php
View file

@ -158,12 +158,12 @@ final class PhabricatorEditEngineConfiguration
// If we don't have an explicit value, don't make any adjustments. // If we don't have an explicit value, don't make any adjustments.
break; break;
} }
}
// If the field isn't lockable, remove any lock we applied. // If the field isn't lockable, remove any lock we applied.
if (!$field->getIsLockable()) { if (!$field->getIsLockable()) {
$field->setIsLocked(false); $field->setIsLocked(false);
} }
}
$fields = $this->reorderFields($fields); $fields = $this->reorderFields($fields);