revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-24 21:48:21 +01:00
Code Issues Releases Wiki Activity

Add <tr /> tags to Maniphest task summary tables

Browse source 
Summary:
That's not how tables work!

Test Plan:
Load maniphest, do not receive a zillion console warnings in Safari.

Reviewed By: aran
Reviewers: aran, jungejason, tuomaspelkonen
CC: aran
Differential Revision: 227
This commit is contained in:
epriestley 2011-05-05 06:29:14 -07:00
parent 03ebbccbc9
commit 7eefbfaa51
1 changed files with 29 additions and 27 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

56
src/applications/maniphest/view/tasksummary/ManiphestTaskSummaryView.php
View file

@ -50,33 +50,35 @@ class ManiphestTaskSummaryView extends AphrontView {
return return
'<table class="maniphest-task-summary">'. '<table class="maniphest-task-summary">'.
'<td class="maniphest-task-number '.$pri_class.'">'. '<tr>'.
'T'.$task->getID(). '<td class="maniphest-task-number '.$pri_class.'">'.
'</td>'. 'T'.$task->getID().
'<td class="maniphest-task-status">'. '</td>'.
($task->getStatus() == ManiphestTaskStatus::STATUS_OPEN '<td class="maniphest-task-status">'.
? 'Open' ($task->getStatus() == ManiphestTaskStatus::STATUS_OPEN
: 'Closed'). ? 'Open'
'</td>'. : 'Closed').
'<td class="maniphest-task-owner">'. '</td>'.
($task->getOwnerPHID() '<td class="maniphest-task-owner">'.
? $handles[$task->getOwnerPHID()]->renderLink() ($task->getOwnerPHID()
: '<em>None</em>'). ? $handles[$task->getOwnerPHID()]->renderLink()
'</td>'. : '<em>None</em>').
'<td class="maniphest-task-name">'. '</td>'.
phutil_render_tag( '<td class="maniphest-task-name">'.
'a', phutil_render_tag(
array( 'a',
'href' => '/T'.$task->getID(), array(
), 'href' => '/T'.$task->getID(),
phutil_escape_html($task->getTitle())). ),
'</td>'. phutil_escape_html($task->getTitle())).
'<td class="maniphest-task-priority">'. '</td>'.
ManiphestTaskPriority::getTaskPriorityName($task->getPriority()). '<td class="maniphest-task-priority">'.
'</td>'. ManiphestTaskPriority::getTaskPriorityName($task->getPriority()).
'<td class="maniphest-task-updated">'. '</td>'.
phabricator_format_timestamp($task->getDateModified()). '<td class="maniphest-task-updated">'.
'</td>'. phabricator_format_timestamp($task->getDateModified()).
'</td>'.
'</tr>'.
'</table>'; '</table>';
} }