From 7f1c07973d9e7afc6bc7732f6b1dda6c5e9cb291 Mon Sep 17 00:00:00 2001 From: Chad Little Date: Mon, 9 Jun 2014 11:46:57 -0700 Subject: [PATCH] Clean up Hovercard CSS Summary: Cleans up some wonkiness in rendering edge cases, like long titles. Test Plan: Test long titles and UI Examples. {F164546} {F164547} Reviewers: epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9433 --- resources/celerity/map.php | 4 ++-- .../css/layout/phabricator-hovercard-view.css | 20 +++++-------------- 2 files changed, 7 insertions(+), 17 deletions(-) diff --git a/resources/celerity/map.php b/resources/celerity/map.php index 2f0cec8dc5..2ce2d6bb39 100644 --- a/resources/celerity/map.php +++ b/resources/celerity/map.php @@ -115,7 +115,7 @@ return array( 'rsrc/css/layout/phabricator-action-list-view.css' => 'dcbfc854', 'rsrc/css/layout/phabricator-crumbs-view.css' => '989a48b6', 'rsrc/css/layout/phabricator-filetree-view.css' => 'fccf9f82', - 'rsrc/css/layout/phabricator-hovercard-view.css' => '92b1cb9b', + 'rsrc/css/layout/phabricator-hovercard-view.css' => 'e010d7db', 'rsrc/css/layout/phabricator-side-menu-view.css' => 'a2ccd7bd', 'rsrc/css/layout/phabricator-source-code-view.css' => '62a99814', 'rsrc/css/phui/calendar/phui-calendar-day.css' => 'de035c8a', @@ -701,7 +701,7 @@ return array( 'phabricator-filetree-view-css' => 'fccf9f82', 'phabricator-flag-css' => '5337623f', 'phabricator-hovercard' => '4f344388', - 'phabricator-hovercard-view-css' => '92b1cb9b', + 'phabricator-hovercard-view-css' => 'e010d7db', 'phabricator-keyboard-shortcut' => '1ae869f2', 'phabricator-keyboard-shortcut-manager' => 'ad7a69ca', 'phabricator-main-menu-view' => '72d1d2ef', diff --git a/webroot/rsrc/css/layout/phabricator-hovercard-view.css b/webroot/rsrc/css/layout/phabricator-hovercard-view.css index 2e58449a5a..8063e9ab51 100644 --- a/webroot/rsrc/css/layout/phabricator-hovercard-view.css +++ b/webroot/rsrc/css/layout/phabricator-hovercard-view.css @@ -45,20 +45,15 @@ } .phabricator-hovercard-body { - float: left; - width: 100%; - padding: 12px 0; + padding: 12px 8px; color: {$darkgreytext}; border-bottom-right-radius: 3px; border-bottom-left-radius: 3px; -} - -.phabricator-hovercard-body-header { - margin: 0 0 0 8px; + position: relative; } .phabricator-hovercard-body-item { - margin: 2px 0 0 8px; + margin: 2px 0 0 0px; } .phabricator-hovercard-body-header { @@ -69,26 +64,21 @@ } .phabricator-hovercard-body .phabricator-hovercard-body-image { - clear: left; - float: left; width: 58px; + position: absolute; } .phabricator-hovercard-body .phabricator-hovercard-body-details { - clear: right; - float: left; - width: 342px; + margin-left: 58px; } .phabricator-hovercard-body .profile-header-picture-frame { float: left; - margin: 0px 8px 0px 8px; width: 50px; height: 50px; background-position: center; background-repeat: no-repeat; } - .phabricator-hovercard-tail { width: 396px; float: left;