1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-23 05:50:55 +01:00

Add required needMembers/needWatchers calls to Project Profile/Subprojects tabs

Summary:
Fixes T12710. See that task for discussion. This is pretty ugly/redundant but not broken.

(Feel free to reject this and pursue something else.)

Test Plan:
  - For a project with active subprojects/milestones, viewed the project profile and subprojects tabs.
  - After patch: they're ugly, but no longer fatal.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12710

Differential Revision: https://secure.phabricator.com/D17882
This commit is contained in:
epriestley 2017-05-15 06:36:28 -07:00
parent 89e567ffd9
commit 7f54f79fd1
2 changed files with 6 additions and 0 deletions

View file

@ -262,6 +262,8 @@ final class PhabricatorProjectProfileController
->setViewer($viewer)
->withParentProjectPHIDs(array($project->getPHID()))
->needImages(true)
->needMembers(true)
->needWatchers(true)
->withStatuses(
array(
PhabricatorProjectStatus::STATUS_ACTIVE,

View file

@ -31,6 +31,8 @@ final class PhabricatorProjectSubprojectsController
->setViewer($viewer)
->withParentProjectPHIDs(array($project->getPHID()))
->needImages(true)
->needMembers(true)
->needWatchers(true)
->withIsMilestone(false)
->execute();
} else {
@ -42,6 +44,8 @@ final class PhabricatorProjectSubprojectsController
->setViewer($viewer)
->withParentProjectPHIDs(array($project->getPHID()))
->needImages(true)
->needMembers(true)
->needWatchers(true)
->withIsMilestone(true)
->setOrderVector(array('milestoneNumber', 'id'))
->execute();