revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-23 05:50:55 +01:00
Code Issues Releases Wiki Activity

Add required needMembers/needWatchers calls to Project Profile/Subprojects tabs

Browse source 
Summary:
Fixes T12710. See that task for discussion. This is pretty ugly/redundant but not broken.

(Feel free to reject this and pursue something else.)

Test Plan:
  - For a project with active subprojects/milestones, viewed the project profile and subprojects tabs.
  - After patch: they're ugly, but no longer fatal.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12710

Differential Revision: https://secure.phabricator.com/D17882
This commit is contained in:
epriestley 2017-05-15 06:36:28 -07:00
parent 89e567ffd9
commit 7f54f79fd1
2 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/project/controller/PhabricatorProjectProfileController.php
View file

@ -262,6 +262,8 @@ final class PhabricatorProjectProfileController
->setViewer($viewer) ->setViewer($viewer)
->withParentProjectPHIDs(array($project->getPHID())) ->withParentProjectPHIDs(array($project->getPHID()))
->needImages(true) ->needImages(true)
->needMembers(true)
->needWatchers(true)
->withStatuses( ->withStatuses(
array( array(
PhabricatorProjectStatus::STATUS_ACTIVE, PhabricatorProjectStatus::STATUS_ACTIVE,

4
src/applications/project/controller/PhabricatorProjectSubprojectsController.php
View file

@ -31,6 +31,8 @@ final class PhabricatorProjectSubprojectsController
->setViewer($viewer) ->setViewer($viewer)
->withParentProjectPHIDs(array($project->getPHID())) ->withParentProjectPHIDs(array($project->getPHID()))
->needImages(true) ->needImages(true)
->needMembers(true)
->needWatchers(true)
->withIsMilestone(false) ->withIsMilestone(false)
->execute(); ->execute();
} else { } else {
@ -42,6 +44,8 @@ final class PhabricatorProjectSubprojectsController
->setViewer($viewer) ->setViewer($viewer)
->withParentProjectPHIDs(array($project->getPHID())) ->withParentProjectPHIDs(array($project->getPHID()))
->needImages(true) ->needImages(true)
->needMembers(true)
->needWatchers(true)
->withIsMilestone(true) ->withIsMilestone(true)
->setOrderVector(array('milestoneNumber', 'id')) ->setOrderVector(array('milestoneNumber', 'id'))
->execute(); ->execute();