From 7f6508af5a3d79ddcc7c6e97864794f657315233 Mon Sep 17 00:00:00 2001 From: Joshua Spence Date: Thu, 18 Jun 2015 22:40:04 +1000 Subject: [PATCH] Add missing execution on archived task query Summary: Fixes T8599. I'm not sure how to reproduce the original issue, but I'm fairly confident that the issue is that the issue is that `execute()` is not called on the query object. Test Plan: Created a Harbormaster build plan with a single "Lease Host" step. Ran `./bin/harbormaster build --plan 1 D1` from the command line and hit the exception as described in T8599. Applied patch and hit a different exception (which I think is just because I don't know how to use #drydock and #harbormaster). Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: hach-que, epriestley, Korvin Maniphest Tasks: T8599 Differential Revision: https://secure.phabricator.com/D13335 --- src/infrastructure/daemon/workers/PhabricatorWorker.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/infrastructure/daemon/workers/PhabricatorWorker.php b/src/infrastructure/daemon/workers/PhabricatorWorker.php index c64135531b..29f3e0ae39 100644 --- a/src/infrastructure/daemon/workers/PhabricatorWorker.php +++ b/src/infrastructure/daemon/workers/PhabricatorWorker.php @@ -199,7 +199,8 @@ abstract class PhabricatorWorker extends Phobject { } $tasks = id(new PhabricatorWorkerArchiveTaskQuery()) - ->withIDs($task_ids); + ->withIDs($task_ids) + ->execute(); foreach ($tasks as $task) { if ($task->getResult() != PhabricatorWorkerArchiveTask::RESULT_SUCCESS) {