revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-22 14:52:41 +01:00
Code Issues Releases Wiki Activity

Make the "Requested Changes to Prior Diff" reviewer icon red, not bluegrey

Browse source 
Summary: See PHI31. The "Accepted Older Revision" icon is (more reasonably) bluegrey, but that rule spilled over here where it doesn't make much sense. "Requested Changes to Prior Diff" remains in effect across updates, but the coloration implies otherwise.

Test Plan:
"Requested Changes to This Diff" (unchanged):

{F5092019}

"Requested Changes to Prior Diff" (now red, previously bluegrey):

{F5092020}

Note that the icons are different so this is technically colorblind-safe, and it's normally not important to distinguish between these two reds anyway.

Reviewers: chad, lvital

Reviewed By: lvital

Subscribers: lvital

Differential Revision: https://secure.phabricator.com/D18385
This commit is contained in:
epriestley 2017-08-10 08:18:56 -07:00
parent 8443366f32
commit 7f90ef2d82
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/differential/view/DifferentialReviewersView.php
View file

@ -116,7 +116,7 @@ final class DifferentialReviewersView extends AphrontView {
} }
} else { } else {
$icon = 'fa-times-circle-o'; $icon = 'fa-times-circle-o';
$color = 'bluegrey'; $color = 'red';
if ($authority_name !== null) { if ($authority_name !== null) {
$label = pht( $label = pht(
'Requested Changes to Prior Diff (by %s)', 'Requested Changes to Prior Diff (by %s)',