From 7fa5e63f0d6506f49a74efec9ead32838cfcdb49 Mon Sep 17 00:00:00 2001 From: Chad Little Date: Thu, 28 May 2015 11:37:02 -0700 Subject: [PATCH] [Redesign] Normalize nav spacing Summary: Ref T8099. Not sure if this was accidentally removed, but `overflow: hidden` saves the day once again. Fixes an issue where different pages had navs starting at different spots based on crumbs or object boxes. Test Plan: Test Projects, People, Dashboards, lots of other navs. All start at 8px now. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T8099 Differential Revision: https://secure.phabricator.com/D13047 --- resources/celerity/map.php | 6 +++--- webroot/rsrc/css/aphront/phabricator-nav-view.css | 5 +++++ 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/resources/celerity/map.php b/resources/celerity/map.php index 50aa72e6d4..f5488cf1e9 100644 --- a/resources/celerity/map.php +++ b/resources/celerity/map.php @@ -7,7 +7,7 @@ */ return array( 'names' => array( - 'core.pkg.css' => '0df8c6bf', + 'core.pkg.css' => '99b01d05', 'core.pkg.js' => 'e4f47dfd', 'darkconsole.pkg.js' => 'e7393ebb', 'differential.pkg.css' => 'bb338e4b', @@ -25,7 +25,7 @@ return array( 'rsrc/css/aphront/notification.css' => '9c279160', 'rsrc/css/aphront/pager-view.css' => '2e3539af', 'rsrc/css/aphront/panel-view.css' => '8427b78d', - 'rsrc/css/aphront/phabricator-nav-view.css' => '949b43d9', + 'rsrc/css/aphront/phabricator-nav-view.css' => '0ecd30a1', 'rsrc/css/aphront/table-view.css' => 'fb17602c', 'rsrc/css/aphront/tokenizer.css' => '04875312', 'rsrc/css/aphront/tooltip.css' => '7672b60f', @@ -714,7 +714,7 @@ return array( 'phabricator-keyboard-shortcut' => '1ae869f2', 'phabricator-keyboard-shortcut-manager' => 'c1700f6f', 'phabricator-main-menu-view' => '4b7ecab2', - 'phabricator-nav-view-css' => '949b43d9', + 'phabricator-nav-view-css' => '0ecd30a1', 'phabricator-notification' => '0c6946e7', 'phabricator-notification-css' => '9c279160', 'phabricator-notification-menu-css' => '713df25a', diff --git a/webroot/rsrc/css/aphront/phabricator-nav-view.css b/webroot/rsrc/css/aphront/phabricator-nav-view.css index 00666d2d8a..d78717ab0f 100644 --- a/webroot/rsrc/css/aphront/phabricator-nav-view.css +++ b/webroot/rsrc/css/aphront/phabricator-nav-view.css @@ -32,6 +32,7 @@ white-space: nowrap; overflow-x: hidden; overflow-y: auto; + padding-top: 8px; } .phabricator-nav-drag { @@ -54,6 +55,10 @@ background-repeat: no-repeat; } +.phabricator-nav-content { + overflow: hidden; +} + .device-desktop .phabricator-standard-page-body .has-drag-nav .phabricator-nav-content { margin-left: 212px;