Show policy information in Differential header

Summary: Ref T603. Moves policy information from a custom field to the header for revisions.

Test Plan: Looked at a revision.

Reviewers: btrahan, chad

Reviewed By: chad

CC: aran

Maniphest Tasks: T603

Differential Revision: https://secure.phabricator.com/D7135

src/__phutil_library_map__.php

@@ -428,7 +428,6 @@ phutil_register_library_map(array(
     'DifferentialUnitFieldSpecification' => 'applications/differential/field/specification/DifferentialUnitFieldSpecification.php',
     'DifferentialUnitStatus' => 'applications/differential/constants/DifferentialUnitStatus.php',
     'DifferentialUnitTestResult' => 'applications/differential/constants/DifferentialUnitTestResult.php',
-    'DifferentialViewPolicyFieldSpecification' => 'applications/differential/field/specification/DifferentialViewPolicyFieldSpecification.php',
     'DiffusionBranchInformation' => 'applications/diffusion/data/DiffusionBranchInformation.php',
     'DiffusionBranchTableController' => 'applications/diffusion/controller/DiffusionBranchTableController.php',
     'DiffusionBranchTableView' => 'applications/diffusion/view/DiffusionBranchTableView.php',
@@ -2500,7 +2499,6 @@ phutil_register_library_map(array(
     'DifferentialTransaction' => 'PhabricatorApplicationTransaction',
     'DifferentialTransactionComment' => 'PhabricatorApplicationTransactionComment',
     'DifferentialUnitFieldSpecification' => 'DifferentialFieldSpecification',
-    'DifferentialViewPolicyFieldSpecification' => 'DifferentialFieldSpecification',
     'DiffusionBranchTableController' => 'DiffusionController',
     'DiffusionBranchTableView' => 'DiffusionView',
     'DiffusionBrowseController' => 'DiffusionController',

src/applications/differential/controller/DifferentialRevisionViewController.php

@@ -232,6 +232,7 @@ final class DifferentialRevisionViewController extends DifferentialController {
     }
 
     $revision_detail = id(new DifferentialRevisionDetailView())
+      ->setUser($user)
       ->setRevision($revision)
       ->setDiff(end($diffs))
       ->setAuxiliaryFields($aux_fields)

src/applications/differential/field/selector/DifferentialDefaultFieldSelector.php

@@ -13,7 +13,6 @@ final class DifferentialDefaultFieldSelector
       new DifferentialReviewersFieldSpecification(),
       new DifferentialReviewedByFieldSpecification(),
       new DifferentialCCsFieldSpecification(),
-      new DifferentialViewPolicyFieldSpecification(),
       new DifferentialLintFieldSpecification(),
       new DifferentialUnitFieldSpecification(),
       new DifferentialCommitsFieldSpecification(),

src/applications/differential/field/specification/DifferentialViewPolicyFieldSpecification.php

@@ -1,25 +0,0 @@
-<?php
-
-final class DifferentialViewPolicyFieldSpecification
-  extends DifferentialFieldSpecification {
-
-  public function shouldAppearOnRevisionView() {
-    return true;
-  }
-
-  public function renderLabelForRevisionView() {
-    return pht('Visible To');
-  }
-
-  public function renderValueForRevisionView() {
-    $user = $this->getUser();
-    $revision = $this->getRevision();
-
-    $descriptions = PhabricatorPolicyQuery::renderPolicyDescriptions(
-      $user,
-      $revision);
-
-    return idx($descriptions, PhabricatorPolicyCapability::CAN_VIEW);
-  }
-
-}

src/applications/differential/view/DifferentialRevisionDetailView.php

@@ -120,7 +120,9 @@ final class DifferentialRevisionDetailView extends AphrontView {
 
   private function renderHeader(DifferentialRevision $revision) {
     $view = id(new PHUIHeaderView())
-      ->setHeader($revision->getTitle($revision));
+      ->setHeader($revision->getTitle($revision))
+      ->setUser($this->getUser())
+      ->setPolicyObject($revision);
 
     $status = $revision->getStatus();
     $status_name =