From 803a05082471aeb4d0e0100a118afd5693e45c10 Mon Sep 17 00:00:00 2001 From: epriestley Date: Wed, 4 Mar 2015 14:36:13 -0800 Subject: [PATCH] Fix an issue with creating new Conpherences Summary: The participant list can sometimes be `null`, which fails when we try to `array_fuse()` it. Test Plan: Created a new thread cleanly. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Differential Revision: https://secure.phabricator.com/D11969 --- src/applications/conpherence/editor/ConpherenceEditor.php | 2 +- .../editor/PhabricatorApplicationTransactionEditor.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/applications/conpherence/editor/ConpherenceEditor.php b/src/applications/conpherence/editor/ConpherenceEditor.php index 75776cadfe..0015d6dd9c 100644 --- a/src/applications/conpherence/editor/ConpherenceEditor.php +++ b/src/applications/conpherence/editor/ConpherenceEditor.php @@ -490,7 +490,7 @@ final class ConpherenceEditor extends PhabricatorApplicationTransactionEditor { foreach ($xactions as $xaction) { $phids = $this->getPHIDTransactionNewValue( $xaction, - $object->getParticipantPHIDs()); + nonempty($object->getParticipantPHIDs(), array())); if (!$phids) { continue; diff --git a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php index d81f9f5c8d..1bcf9e213d 100644 --- a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php +++ b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php @@ -1413,7 +1413,7 @@ abstract class PhabricatorApplicationTransactionEditor PhabricatorApplicationTransaction $xaction, $old = null) { - if ($old) { + if ($old !== null) { $old = array_fuse($old); } else { $old = array_fuse($xaction->getOldValue());