revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-02-09 13:28:29 +01:00
Code Issues Releases Wiki Activity

Add transparency to Pholio Edit thumbs

Browse source 
Summary: Makes the background transparent for uploaded thumbs. This page in general needs lots of work, but here's the minimum. Fixes T10986

Test Plan: Edit a Mock with a transparent jeff.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Maniphest Tasks: T10986

Differential Revision: https://secure.phabricator.com/D15957
This commit is contained in:
Chad Little 2016-05-20 13:36:11 -07:00
parent 969d3be035
commit 804a5db41a
3 changed files with 20 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
resources/celerity/map.php
View file

@ -82,7 +82,7 @@ return array(
'rsrc/css/application/paste/paste.css' => '1898e534', 'rsrc/css/application/paste/paste.css' => '1898e534',
'rsrc/css/application/people/people-profile.css' => '2473d929', 'rsrc/css/application/people/people-profile.css' => '2473d929',
'rsrc/css/application/phame/phame.css' => '737792d6', 'rsrc/css/application/phame/phame.css' => '737792d6',
'rsrc/css/application/pholio/pholio-edit.css' => '3ad9d1ee', 'rsrc/css/application/pholio/pholio-edit.css' => 'b15fec4a',
'rsrc/css/application/pholio/pholio-inline-comments.css' => '8e545e49', 'rsrc/css/application/pholio/pholio-inline-comments.css' => '8e545e49',
'rsrc/css/application/pholio/pholio.css' => 'ca89d380', 'rsrc/css/application/pholio/pholio.css' => 'ca89d380',
'rsrc/css/application/phortune/phortune-credit-card-form.css' => '8391eb02', 'rsrc/css/application/phortune/phortune-credit-card-form.css' => '8391eb02',
@ -804,7 +804,7 @@ return array(
'phabricator-zindex-css' => '5b6fcf3f', 'phabricator-zindex-css' => '5b6fcf3f',
'phame-css' => '737792d6', 'phame-css' => '737792d6',
'pholio-css' => 'ca89d380', 'pholio-css' => 'ca89d380',
'pholio-edit-css' => '3ad9d1ee', 'pholio-edit-css' => 'b15fec4a',
'pholio-inline-comments-css' => '8e545e49', 'pholio-inline-comments-css' => '8e545e49',
'phortune-credit-card-form' => '2290aeef', 'phortune-credit-card-form' => '2290aeef',
'phortune-credit-card-form-css' => '8391eb02', 'phortune-credit-card-form-css' => '8391eb02',

11
src/applications/pholio/view/PholioUploadedImageView.php
View file

@ -42,12 +42,19 @@ final class PholioUploadedImageView extends AphrontView {
PhabricatorFileThumbnailTransform::TRANSFORM_PINBOARD); PhabricatorFileThumbnailTransform::TRANSFORM_PINBOARD);
$thumbnail_uri = $file->getURIForTransform($xform); $thumbnail_uri = $file->getURIForTransform($xform);
$thumb_img = phutil_tag(
'img',
array(
'class' => 'pholio-thumb-img',
'src' => $thumbnail_uri,
));
$thumb_frame = phutil_tag( $thumb_frame = phutil_tag(
'div', 'div',
array( array(
'class' => 'pholio-thumb-frame', 'class' => 'pholio-thumb-frame',
'style' => 'background-image: url('.$thumbnail_uri.');', ),
)); $thumb_img);
$handle = javelin_tag( $handle = javelin_tag(
'div', 'div',

18
webroot/rsrc/css/application/pholio/pholio-edit.css
View file

@ -17,8 +17,8 @@
.pholio-thumb-box { .pholio-thumb-box {
margin: 2px 0; margin: 2px 0;
float: left; float: left;
background: #f7f7f7; background: {$lightgreybackground};
border: 1px solid #D5D9DF; border: 1px solid {$lightgreyborder};
border-radius: 3px; border-radius: 3px;
width: 296px; width: 296px;
overflow: hidden; overflow: hidden;
@ -38,16 +38,16 @@
margin: 0 auto; margin: 0 auto;
} }
.pholio-thumb-frame { .pholio-thumb-img {
background-color: #ffffff; max-width: 280px;
background-position: center center; max-height: 210px;
background-repeat: no-repeat;
background-size: 280px 210px;
width: 280px;
height: 210px;
padding: 8px; padding: 8px;
} }
.pholio-thumb-frame {
background: url('/rsrc/image/checker_lighter.png');
}
.device .pholio-thumb-frame { .device .pholio-thumb-frame {
width: 100%; width: 100%;
} }