From 804e7a6e065a6aab79ebc4c1c983ff5528c41d1b Mon Sep 17 00:00:00 2001 From: epriestley Date: Fri, 3 Jun 2016 12:13:07 -0700 Subject: [PATCH] When a user enables/disables DarkConsole, forget their console UI visibility setting Summary: Ref T4103. This primarily makes sure the console gets turned on when you enable it so you aren't like "where's the console???" Test Plan: Enabled console, saw console. Reviewers: chad Reviewed By: chad Maniphest Tasks: T4103 Differential Revision: https://secure.phabricator.com/D16030 --- .../setting/PhabricatorDarkConsoleSetting.php | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/src/applications/settings/setting/PhabricatorDarkConsoleSetting.php b/src/applications/settings/setting/PhabricatorDarkConsoleSetting.php index be78487a89..28ee90788e 100644 --- a/src/applications/settings/setting/PhabricatorDarkConsoleSetting.php +++ b/src/applications/settings/setting/PhabricatorDarkConsoleSetting.php @@ -42,5 +42,17 @@ final class PhabricatorDarkConsoleSetting ); } + public function expandSettingTransaction($object, $xaction) { + // If the user has hidden the DarkConsole UI, forget their setting when + // they enable or disable it. + return array( + $xaction, + $this->newSettingTransaction( + $object, + PhabricatorDarkConsoleVisibleSetting::SETTINGKEY, + 1), + ); + } + }