revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-19 05:12:41 +01:00
Code Issues Releases Wiki Activity

Fix horrible broken mess in 304 handling

Browse source 
Summary:
Sending a response body in a 304 triggers some crazy broken behavior in Safari +
Apache that I never hit during testing. Be spec-compliant.

Test Plan:
Mashed reload a bunch on a .php page with Safari + Apache against localhost.

Reviewed By: tuomaspelkonen
Reviewers: tuomaspelkonen, jungejason, aran, rm
CC: aran, tuomaspelkonen
Differential Revision: 261
This commit is contained in:
epriestley 2011-05-10 16:08:20 -07:00
parent f7e2b03077
commit 80698aba6f
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/aphront/response/304/Aphront304Response.php
View file

@ -26,7 +26,10 @@ class Aphront304Response extends AphrontResponse {
}
public function buildResponseString() {
return '304 Not Modified';
// IMPORTANT! According to the HTTP/1.1 spec (RFC 2616) a 304 response
// "MUST NOT" have any content. Apache + Safari strongly agree, and
// completely flip out and you start getting 304s for no-cache pages.
return null;
}
}