revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-29 17:00:59 +01:00
Code Issues Releases Wiki Activity

Fix an issue where paths could bleed across repos in Owners

Browse source 
Summary:
Ref T8320. I missed this a while ago and then it came to me in a dream.

Only consider paths in the same repo when looking at ownership.

(I think this is rarely reachable in practice.)

Test Plan: Verified that files and commits still listed ownership properly.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T8320

Differential Revision: https://secure.phabricator.com/D14022
This commit is contained in:
epriestley 2015-09-01 08:07:06 -07:00
parent ce7c2097b2
commit 809c7fb4f3
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/applications/owners/query/PhabricatorOwnersPackageQuery.php
View file

@ -372,6 +372,11 @@ final class PhabricatorOwnersPackageQuery
$include = false; $include = false;
foreach ($package->getPaths() as $package_path) { foreach ($package->getPaths() as $package_path) {
if ($package_path->getRepositoryPHID() != $repository_phid) {
// If this path is for some other repository, skip it.
continue;
}
$strength = $package_path->getPathMatchStrength($path); $strength = $package_path->getPathMatchStrength($path);
if ($strength > $best_match) { if ($strength > $best_match) {
$best_match = $strength; $best_match = $strength;